[extra-addons-trunk] product_image_olbs : duplicate product crash

Bug #1017960 reported by Alexandre Fayolle - camptocamp
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Won't Fix
Undecided
Alexandre Fayolle - camptocamp

Bug Description

I get the following error when trying to duplicate a product with linked images:

2012-06-26 13:10:10,424 4812 ERROR ? openerp.osv.osv: Uncaught exception
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py", line 121, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py", line 164, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 3406, in read
    result = self._read_flat(cr, user, select, fields, context, load)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 3529, in _read_flat
    res2 = self._columns[f].get(cr, self, ids, f, user, context=context, values=res)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/fields.py", line 1132, in get
    result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/addons/product_images_olbs/product.py", line 52, in _get_main_image
    res[id] = image.file
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 476, in __getattr__
    return self[name]
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 391, in __getitem__
    field_values = self._table.read(self._cr, self._uid, ids, field_names, context=self._context, load="_classic_write")
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 3406, in read
    result = self._read_flat(cr, user, select, fields, context, load)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py", line 3529, in _read_flat
    res2 = self._columns[f].get(cr, self, ids, f, user, context=context, values=res)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/fields.py", line 1132, in get
    result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/addons/product_images_olbs/product_images.py", line 119, in _get_image
    res[each] = self.get_image(cr, uid, each, context=context)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/addons/product_images_olbs/product_images.py", line 100, in get_image
    full_path = self._image_path(cr, uid, image, context=context)
  File "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/addons/product_images_olbs/product_images.py", line 90, in _image_path
    '%s%s' % (image.name or '', image.extention or ''))
  File "/usr/lib/python2.6/posixpath.py", line 65, in join
    if b.startswith('/'):
AttributeError: 'bool' object has no attribute 'startswith'

This is caused by the new product having False as default_code.

Related branches

summary: - [extra-addons] product_image_olbs : duplicate product crash
+ [extra-addons-trunk] product_image_olbs : duplicate product crash
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello Alexandre Fayolle,

This module is part of the extra-addons, which are maintained by the community, including all the modules created by "OpenERP" or "Tiny", as none of these are actively developed by our teams anymore.

If you or anyone from the community would like to work on it, please mark the bug as "In progress" and assign it to yourself (or ask us or anyone from OpenERP Drivers to do it for you). In the mean time, we will mark it as "Won't fix" to indicate that no further progress is expected at the moment.

For more detail you can contact related author.

Thank you!

Changed in openobject-addons:
status: New → Won't Fix
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote : Re: [Bug 1017960] Re: [extra-addons-trunk] product_image_olbs : duplicate product crash
Download full text (5.0 KiB)

Hello Alexandre,

could you please try with the version of he module hosted in this branch:
https://code.launchpad.net/~extra-addons-commiter/product-extra-addons/trunk

Because of the half assumed half doable extra-addons decommissioning we are
moving out modules in more maintainable branches. he thing is we today like
repository meta-information in __openerp__.py files so we could properly
point users to the right dependencies... But please tell us if this version
has the same issue or not. hanks in advance.

On Wed, Jun 27, 2012 at 3:23 AM, Jignesh Rathod(OpenERP) <
<email address hidden>> wrote:

> Hello Alexandre Fayolle,
>
> This module is part of the extra-addons, which are maintained by the
> community, including all the modules created by "OpenERP" or "Tiny", as
> none of these are actively developed by our teams anymore.
>
> If you or anyone from the community would like to work on it, please
> mark the bug as "In progress" and assign it to yourself (or ask us or
> anyone from OpenERP Drivers to do it for you). In the mean time, we will
> mark it as "Won't fix" to indicate that no further progress is expected
> at the moment.
>
> For more detail you can contact related author.
>
> Thank you!
>
>
>
> ** Changed in: openobject-addons
> Status: New => Won't Fix
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/1017960
>
> Title:
> [extra-addons-trunk] product_image_olbs : duplicate product crash
>
> Status in OpenERP Addons (modules):
> Won't Fix
>
> Bug description:
> I get the following error when trying to duplicate a product with
> linked images:
>
> 2012-06-26 13:10:10,424 4812 ERROR ? openerp.osv.osv: Uncaught exception
> Traceback (most recent call last):
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 121, in wrapper
> return f(self, dbname, *args, **kwargs)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 176, in execute
> res = self.execute_cr(cr, uid, obj, method, *args, **kw)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 164, in execute_cr
> return getattr(object, method)(cr, uid, *args, **kw)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
> line 3406, in read
> result = self._read_flat(cr, user, select, fields, context, load)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
> line 3529, in _read_flat
> res2 = self._columns[f].get(cr, self, ids, f, user, context=context,
> values=res)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/fields.py",
> line 1132, in get
> result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/addons/product_images_olbs/product.py",
> line 52, in _get_main_image
> res[id] = image.file
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/se...

Read more...

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :
Download full text (5.4 KiB)

sorry, writing to fast on a keyboard too slow:
"he thing is we today like" -> "the thing is we are today lacking of
repository meta-information"

On Wed, Jun 27, 2012 at 5:40 AM, Raphael Valyi <email address hidden> wrote:

> Hello Alexandre,
>
> could you please try with the version of he module hosted in this branch:
>
> https://code.launchpad.net/~extra-addons-commiter/product-extra-addons/trunk
>
> Because of the half assumed half doable extra-addons decommissioning we
> are moving out modules in more maintainable branches. he thing is we today
> like repository meta-information in __openerp__.py files so we could
> properly point users to the right dependencies... But please tell us if
> this version has the same issue or not. hanks in advance.
>
>
> On Wed, Jun 27, 2012 at 3:23 AM, Jignesh Rathod(OpenERP) <
> <email address hidden>> wrote:
>
>> Hello Alexandre Fayolle,
>>
>> This module is part of the extra-addons, which are maintained by the
>> community, including all the modules created by "OpenERP" or "Tiny", as
>> none of these are actively developed by our teams anymore.
>>
>> If you or anyone from the community would like to work on it, please
>> mark the bug as "In progress" and assign it to yourself (or ask us or
>> anyone from OpenERP Drivers to do it for you). In the mean time, we will
>> mark it as "Won't fix" to indicate that no further progress is expected
>> at the moment.
>>
>> For more detail you can contact related author.
>>
>> Thank you!
>>
>>
>>
>> ** Changed in: openobject-addons
>> Status: New => Won't Fix
>>
>> --
>> You received this bug notification because you are subscribed to OpenERP
>> Addons.
>> https://bugs.launchpad.net/bugs/1017960
>>
>> Title:
>> [extra-addons-trunk] product_image_olbs : duplicate product crash
>>
>> Status in OpenERP Addons (modules):
>> Won't Fix
>>
>> Bug description:
>> I get the following error when trying to duplicate a product with
>> linked images:
>>
>> 2012-06-26 13:10:10,424 4812 ERROR ? openerp.osv.osv: Uncaught exception
>> Traceback (most recent call last):
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
>> line 121, in wrapper
>> return f(self, dbname, *args, **kwargs)
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
>> line 176, in execute
>> res = self.execute_cr(cr, uid, obj, method, *args, **kw)
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
>> line 164, in execute_cr
>> return getattr(object, method)(cr, uid, *args, **kw)
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
>> line 3406, in read
>> result = self._read_flat(cr, user, select, fields, context, load)
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
>> line 3529, in _read_flat
>> res2 = self._columns[f].get(cr, self, ids, f, user, context=context,
>> values=res)
>> File
>> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/fields.py",
>> line 1132, in get
>> result = self....

Read more...

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

On 27/06/2012 08:23, Jignesh Rathod(OpenERP) wrote:
> Hello Alexandre Fayolle,
>
> This module is part of the extra-addons, which are maintained by the
> community, including all the modules created by "OpenERP" or "Tiny", as
> none of these are actively developed by our teams anymore.
>
> If you or anyone from the community would like to work on it, please
> mark the bug as "In progress" and assign it to yourself (or ask us or
> anyone from OpenERP Drivers to do it for you). In the mean time, we will
> mark it as "Won't fix" to indicate that no further progress is expected
> at the moment.
>
> For more detail you can contact related author.
>
> Thank you!
>
>
>
> ** Changed in: openobject-addons
> Status: New => Won't Fix
>

Hello Jignesh,

I have assigned the bug to me, but I cannot set the bug status to "in
progress", probably due to some permission I don't have on the project.
Could you please update the status for me?

Thanks in advance.

--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 92

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

Changed in openobject-addons:
assignee: nobody → Alexandre Fayolle @ camptocamp (alexandre-fayolle-c2c)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

On 27/06/2012 10:40, Raphaël Valyi - http://www.akretion.com wrote:
> Hello Alexandre,
>
> could you please try with the version of he module hosted in this branch:
> https://code.launchpad.net/~extra-addons-commiter/product-extra-addons/trunk
>
> Because of the half assumed half doable extra-addons decommissioning we are
> moving out modules in more maintainable branches. he thing is we today like
> repository meta-information in __openerp__.py files so we could properly
> point users to the right dependencies... But please tell us if this version
> has the same issue or not. hanks in advance.
>
>

Hello Raphael,

I have submitted a merge request for the bug. I'll adapt the patch for
the product-extra-addons branch and submit another merge request.

I have the feeling that tracking the various forked branches is going to
be a major pain...

--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 92r

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :
Download full text (5.4 KiB)

On Wed, Jun 27, 2012 at 7:24 AM, Alexandre Fayolle @ camptocamp <
<email address hidden>> wrote:

> On 27/06/2012 10:40, Raphaël Valyi - http://www.akretion.com wrote:
> > Hello Alexandre,
> >
> > could you please try with the version of he module hosted in this branch:
> >
> https://code.launchpad.net/~extra-addons-commiter/product-extra-addons/trunk
> >
> > Because of the half assumed half doable extra-addons decommissioning we
> are
> > moving out modules in more maintainable branches. he thing is we today
> like
> > repository meta-information in __openerp__.py files so we could properly
> > point users to the right dependencies... But please tell us if this
> version
> > has the same issue or not. hanks in advance.
> >
> >
>
> Hello Raphael,
>
> I have submitted a merge request for the bug. I'll adapt the patch for
> the product-extra-addons branch and submit another merge request.
>
> I have the feeling that tracking the various forked branches is going to
> be a major pain...
>

IMHO the plan should be: get that fu*ing repository dependencies meta-data
inside the __openerp__.py file format.
Then eventually get 1 branch per module as keeping things in synch may
finally be something possible (today it's nearly impossible as you see).
Then eventually move modules to something lightweight and efficient like
github and get a project per module, just like it's done for usual rubygems
and many other packages in any language. Will we ever see that in action
one day? Let's hope...

>
> --
> Alexandre Fayolle
> Chef de Projet
> Tel : + 33 (0)4 79 26 57 92r
>
> Camptocamp France SAS
> Savoie Technolac, BP 352
> 73377 Le Bourget du Lac Cedex
> http://www.camptocamp.com
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/1017960
>
> Title:
> [extra-addons-trunk] product_image_olbs : duplicate product crash
>
> Status in OpenERP Addons (modules):
> Won't Fix
>
> Bug description:
> I get the following error when trying to duplicate a product with
> linked images:
>
> 2012-06-26 13:10:10,424 4812 ERROR ? openerp.osv.osv: Uncaught exception
> Traceback (most recent call last):
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 121, in wrapper
> return f(self, dbname, *args, **kwargs)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 176, in execute
> res = self.execute_cr(cr, uid, obj, method, *args, **kw)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/osv.py",
> line 164, in execute_cr
> return getattr(object, method)(cr, uid, *args, **kw)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
> line 3406, in read
> result = self._read_flat(cr, user, select, fields, context, load)
> File
> "/srv/openerp/instances/openerp_prod_alpesdeveloppement/src/server/openerp/osv/orm.py",
> line 3529, in _read_flat
> res2 = self._columns[f].get(cr, self, ids, f, user, context=context,
> values=res)
> File
> "/srv/openerp/instances/openerp_prod_a...

Read more...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.