Button for Show/Hide Sampler Section not hiding

Bug #1009547 reported by harry lime
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
RJ Skerry-Ryan

Bug Description

I'm using mixxx with DJ2GO and various controls set on my keyboard. I've assigned one of the DJ2GO buttons (the back button) to show/hide the Sampler Section.

When pressing, the Samplers do indeed appear but pressing again does not hide them.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I've also seen a case where if you press the button they show, but when you release it they hide again.

We could fix this by making the COs we create ControlPushButtons (set to toggle) instead of ControlObjects. I think that should be safe to change without breaking anything.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 1.11.0
Revision history for this message
harry lime (ub7-marcus) wrote :

"I've also seen a case where if you press the button they show, but when you release it they hide again."

I messed around trying that without any effect.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

The fix I described in #1 seems to work for keyboard bindings and I assume it will also work for MIDI.

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
status: Confirmed → Fix Committed
Revision history for this message
harry lime (ub7-marcus) wrote :

just been trying out the new Beta version of Mixxx and the show/hide sampler feature assigned to a dj2go button seems to work fine.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6512

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.