ecryptfs-recover-private option --rw prevents recognition of directory parameter

Confirmed, this only seems to happen when the command is typed like "ecryptfs-recover-private --rw /path/to/dir", but if the command is typed as "ecryptfs-recover-private /path/to/dir --rw" then it uses the specified directory as it should. This makes me think that it is something wrong with how command line arguments are parsed.

Confirmed:

$ apt-cache policy ecryptfs-utils
ecryptfs-utils:
  Installed: 87-0ubuntu1.3
  Candidate: 87-0ubuntu1.3
  Version table:
 *** 87-0ubuntu1.3 0
        500 http://archive.ubuntu.com/ubuntu/ natty-updates/main i386 Packages
        100 /var/lib/dpkg/status
     87-0ubuntu1.2 0
        500 http://security.ubuntu.com/ubuntu/ natty-security/main i386 Packages
     87-0ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ natty/main i386 Packages

The logic of the code currently is:

- if the first argument is a directory ignore all other arguments continue
- otherwise search the entire system for .Private directories, and then check if the first argument was --rw

In all cases only the first command line argument is checked.

I recently came across this bug, and it appears the fix is fairly trivial and consists of two parts:

#1. Move the --rw detection before the directory detection. rw is now always correctly detected
#2. Add a elif clause to detect if the second argument is a folder, but not the first, as is likely the case when the --rw flag is passed in. if it is, the shift the arguments, and do the same as the first if statement (ie. set the dirs variable)

Attached is my patch

Thanks for tracking down the problem, timtoo, and thanks for the patch, Patrick.

What I ended up committing was just slightly different than Patrick's patch.

please release fixed version... it's still not in 12.04 repository.
thanks.

Bertrand, I installed Dustin's PPA:
<https://launchpad.net/~ecryptfs/+archive/ppa>
eCryptfs PPA
  “eCryptfs” team eCryptfs PPA
on 12.04 and it's working for me. You might want to give that a try.

On 12/30/2013 04:30 PM, NoOp wrote:
> Bertrand, I installed Dustin's PPA:
> <https://launchpad.net/~ecryptfs/+archive/ppa>
> eCryptfs PPA
> “eCryptfs” team eCryptfs PPA
> on 12.04 and it's working for me. You might want to give that a try.
>

Scratch that. I had to purge the ppa in order to have the /home folder
decrypt on boot.

Tyler: when can we expect this to be fixed for 12.04?