Percona Toolkit moved to https://jira.percona.com/projects/PT

pt-table-sync --ignore-* options don't work with --replicate

Bug #1002365 reported by Daniel Nichter
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
High
Daniel Nichter
Percona Toolkit moved to https://jira.percona.com/projects/PT 2.1.2
2.0
Fix Released
High
Daniel Nichter
Percona Toolkit moved to https://jira.percona.com/projects/PT 2.0.5
2.1
Fix Released
High
Daniel Nichter
Percona Toolkit moved to https://jira.percona.com/projects/PT 2.1.2

Bug Description

There are tests for this (schema filters with --replicate), but there's no specific test for --replicate and --ignore-tables, so there could very well be a bug lurking here.

Related branches

lp:~percona-toolkit-dev/percona-toolkit/fix-sync-ignore-bug-1002365
Daniel Nichter: Approve
Diff: 286 lines (+127/-47)
3 files modified
bin/pt-table-sync (+52/-44)
lib/TableChecksum.pm (+1/-2)
t/pt-table-sync/filters.t (+74/-1)
lp:~percona-toolkit-dev/percona-toolkit/fix-sync-ignore-bug-1002365-2.0
Daniel Nichter: Approve
Diff: 2885 lines (+1834/-520)
11 files modified
bin/pt-table-sync (+580/-423)
lib/SchemaIterator.pm (+26/-44)
lib/TableChecksum.pm (+1/-2)
t/lib/SchemaIterator.t (+9/-50)
t/lib/samples/SchemaIterator/all-dbs-tbls-5.0.txt (+421/-0)
t/lib/samples/SchemaIterator/all-dbs-tbls.txt (+486/-0)
t/lib/samples/SchemaIterator/resume-from-ignored-sakila-payment-5.0.txt (+52/-0)
t/lib/samples/SchemaIterator/resume-from-ignored-sakila-payment.txt (+49/-0)
t/lib/samples/SchemaIterator/resume-from-sakila-payment-5.0.txt (+70/-0)
t/lib/samples/SchemaIterator/resume-from-sakila-payment.txt (+66/-0)
t/pt-table-sync/filters.t (+74/-1)
Daniel Nichter (daniel-nichter)
tags: added: percona-21967
Daniel Nichter (daniel-nichter)
summary: - Some schema filters don't work with pt-table-sync --replicate
+ pt-table-sync --ignore-* options don't work with --replicate
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

I have reproduced this bug. Turns out, none of the --ignore-* options are applied to --replicate which uses filter_diffs() internally. It should use SchemaIterator::table_is_allowed() and friends instead.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

FIxing this in 2.0 required more extensive work. 2.0 was using an old SchemaIterator, but now it's using the latest from 2.1.

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

If we find in future cases that a bug is pretty intrusive to fix in the non-current series I'd advocate not fixing it; only fix "easy wins" in the old version. In reality very few people should be using the old versions; it isn't like RHEL where people want to stay on a single version for 8 years.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-314

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.