Comment 1 for bug 1313689

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

I re-open the bug cause we still have trouble on this one. Making the import of a file manually still raise the error mention above.

I see here 2 remaining troubles:

 * The _insert_lines and _update_line method in *_base_completion/statement.py should call the symbol_f method to prorperly initiate the default value (e.g. integer default null value should be Null not False).

 * The mechanism that allow to have a null account_id in bank statement line should be part of *_base_completion, not *_base_import.

My args:

  - account_bank_statement_ext should keep the original behavior where account_id is mandatory

  - account_statement_completion provide a way of completing a statement line from only partial info, it is his responsability to provide an account_id if none has been provided. So IMO this is in this module that we should allow not to provide an account_id for a line. But then, required one for the statement confirmation.

  - account_statement_base_import which depends on account_statement_completion will benefit from that

Regards,