TAPAAL

lp:~yrke/tapaal/modelControlsDrawingsurface

Created by Kenneth Yrke Jørgensen on 2019-06-26 and last modified on 2020-04-12

Changed:
  - Encapsulated view, no longer called directly, manged via Model, view is updated if Model is connected to view
  - Moved list of all objets from view to Datalyer, mainly used by seletion manger
  - datalayer now track ArcPathPoints,
  - Chnaged on delete of arc also changes stuff in underapprox and remove timing information
  - Moved net change status from view to TabContent
  - Removed calles to repaintAll, when not needed

Test:
  - Adding / removing components
  - Undo/redo for all components
  - Save / reload
  - select and deselet, select all, etc.
  - drawing of arc and arcpath,
  - underapprox is working correctly (special case where arc is removed)
  - test removing of transport as is working in remove timing information
  - Save and Close corretly respect the net changed state
  - Change tabs and in and out of anitmation mode, to check there is no problems with repaints

TODO:
[x] arc path point are not removed from model when a arc is deleted? (before they where just added to the view)

XXX:
  [ ] Possible bug, underapprox, according to code control flow, no arcs are removed, check is alwasys not null
  [X ] Possible bug, remove timing information, the removing of transport arc might depend of the order is witch a transport arc is added to model, if arc 2 is added before arc1 i think the remove transport arc will only create the output arc. (Should no longer be a problem after fix for model problem)
  [X] Error when removing timing information as new arc is added before old is removed (exception, after changes to model)

Get this branch:: bzr branch lp:~yrke/tapaal/modelControlsDrawingsurface

Only Kenneth Yrke Jørgensen can upload to this branch. If you are Kenneth Yrke Jørgensen please log in for upload directions.

Branch merges

No branches dependent on this one.

Related bugs

Bug #1834490: Undo delete fails when selecting and deleting to connected object without selecting the arc	Undecided	Fix Released
Bug #1834839: Canceling drawing transportArc leaves "half" arc	Undecided	Fix Released

Link a bug report

Related blueprints

tapaal 4 dev (Low)

Branch information

Owner:: Kenneth Yrke Jørgensen

Project:: TAPAAL

Status:: Merged

Recent revisions

1092. By Kenneth Yrke Jørgensen on 2019-07-02: Removed serialVersionUID
1091. By Kenneth Yrke Jørgensen on 2019-07-02: Removed unneded call to repaint
1090. By Kenneth Yrke Jørgensen on 2019-07-02: Removed unneded call to repaint
1089. By Kenneth Yrke Jørgensen on 2019-07-02: Moved netChanged trancking from view to TabContent
1088. By Kenneth Yrke Jørgensen on 2019-07-02: Merged with dev
1087. By Kenneth Yrke Jørgensen on 2019-07-02: Removed unused method
1086. By Kenneth Yrke Jørgensen on 2019-07-01: Repaint not happens in view (not model)
1085. By Kenneth Yrke Jørgensen on 2019-07-01: Removing objects not validates and repaints the view
1084. By Kenneth Yrke Jørgensen on 2019-07-01: Addeing new objects not validates and repaints the view
1083. By Kenneth Yrke Jørgensen on 2019-07-01: Removed unused method

Branch metadata

Branch format:: Branch format 7

Repository format:: Bazaar repository format 2a (needs bzr 1.16 or later)

Stacked on:: lp:tapaal

This branch contains Public information

Everyone can see this information.

Subscribers

Kenneth Yrke Jørg...