lp:~victored/contractor/fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:contractor/0.3 at revision 116

Sergey "Shnatsel" Davidoff: Approve on 2013-05-11

Victor Martinez (community): Abstain on 2013-05-11

Diff: 1949 lines (+856/-927)

19 files modified

src/Application.vala (+61/-0)
src/CMakeLists.txt (+28/-18)
src/Contract.vala (+43/-190)
src/ContractDirectory.vala (+65/-0)
src/ContractFile.vala (+48/-0)
src/ContractKeyFile.vala (+110/-0)
src/ContractManager.vala (+60/-0)
src/ContractSorter.vala (+28/-0)
src/ContractSource.vala (+79/-0)
src/DBusService.vala (+45/-136)
src/FileEnumerator.vala (+69/-0)
src/FileService.vala (+36/-185)
src/GenericContract.vala (+23/-0)
src/MimeTypeManager.vala (+71/-0)
src/String.vala (+22/-0)
src/Translations.vala (+44/-0)
src/ablage (+0/-394)
src/config.vala.cmake (+0/-4)
src/main.vala (+24/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1026317: Check Contracts validity when loading it.	Wishlist	Fix Released
Bug #1173202: Conditional contracts rely on volatile display name	High	Fix Released

Link a bug report

Related blueprints

129. By Victor Martinez on 2013-05-11

Don't store a GAppInfo permanently and move contract-loading code to ContractSource.vala

128. By Victor Martinez on 2013-05-11

Make sure contract data directories are loaded in the correct order:
(1) User's data dir.
(2) System-wide directories. This is sorted by priority too.

127. By Victor Martinez on 2013-05-06

Check if mandatory contract key values are valid while loading a contract.

When loading a contract, verify that the keys Name, Description, Exec and MimeType contain valid values, and skip the contract if they do not. Verification of the presence of these keys in the contract file was already implemented, so this revision does not need to add that.

Fixes lp:1026317.

126. By Victor Martinez on 2013-05-03

Don't load a contract if the file specified by TryExec is not available.

Currently the contract will not become available once the required executable is installed. Users would have to wait until the next session or restart contractor, which is unlikely to happen.

125. By Victor Martinez on 2013-05-03

Merge trunk

124. By Victor Martinez on 2013-05-02

Fix issues with localization

123. By Victor Martinez on 2013-05-02

Improve mimetype list validator

122. By Victor Martinez on 2013-05-02

Add guard against duplicate contracts.

Skip a contract if another contract with the same ID already exists.

121. By Victor Martinez on 2013-05-02

No need to guard the code against multiple conditional mimetypes since support for them has landed already.

120. By Victor Martinez on 2013-05-01

Lookup contracts in the user's data directory as well (Usually located at ~./local/share/contractor)