lp:~unity-api-team/unity-scopes-api/multi-arch-click

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-scopes-api/devel at revision 556

Paweł Stołowski (community): Approve on 2014-12-09

Michi Henning (community): Approve on 2014-12-09

Diff: 206 lines (+106/-6)

8 files modified

CMakeLists.txt (+4/-0)
doc/tutorial.dox (+38/-0)
scoperegistry/scoperegistry.cpp (+51/-5)
scoperunner/scoperunner.cpp (+3/-0)
src/scopes/internal/RegistryObject.cpp (+1/-0)
test/gtest/scopes/Registry/scopes/testscopeA/CMakeLists.txt (+4/-0)
test/gtest/scopes/Registry/scopes/testscopeB/CMakeLists.txt (+4/-0)
test/gtest/scopes/Registry/scopes/testscopeB/testscopeB.ini.in (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1398998: Cannot provide multi-arch click packages for scopes

Undecided

Fix Released

Link a bug report

Related blueprints

561. By Pete Woods on 2014-12-09

There's a different varible name now

560. By Pete Woods on 2014-12-09

Don't need to run dpkg!

559. By Pete Woods on 2014-12-08

Spelling

558. By Pete Woods on 2014-12-08

Multi-arch scoperunner docs

557. By Pete Woods on 2014-12-08

Docs for multi-arch

556. By Pete Woods on 2014-12-08

Add tests to utilize new arch-aware codepaths, and fix revealed bug

555. By Pete Woods on 2014-12-08

Multi-arch support - search paths now include GNU triplet as first option

554. By Michi Henning on 2014-12-08

Changed run_scope() to not create a separate run time up-front just so it can
push the state notification when registry when the scope finishes. This has
two advantages:

- We don't create an extra eleven threads that hang around and do nothing for the
  entire life time of the scope.

- We don't create two run times with the same name (as was happening previously).
  The run time IDs must be unique because they are used to derive other things
  that must be unique, such as socket names and log file names. In particular,
  the duplicate run time IDs caused the log file to get corrupted.

This solution is better than what we had, but still sub-optimal because we are still creating a separate run time at the end just so we can tell the registry that the scope has stopped. It would be better to bury these notifications in the middleware, where we can take short-cuts without all the overhead of outgoing thread pools and the like.

Also deprecated the run_scope() overload that takes a Runtime.ini param. That one was not needed, and not called by anyone (including the Go implementation).

We need to remember to strip this method from Runtime next time we do an ABI incompatible release.

Stripped out a bunch of redundant "mutable" in RuntimeImpl.h.

Approved by Marcus Tomlinson, PS Jenkins bot.

553. By Michi Henning on 2014-12-05

Generated convenience header wasn't generating #pragma once. Fixes: https://bugs.launchpad.net/bugs/1385360.

Approved by PS Jenkins bot, Marcus Tomlinson.

552. By Marcus Tomlinson on 2014-12-03

* Update the accounts we already know about when refresh_service_statuses() is called.

* Remove the refresh_services_no_main_loop test as refresh_service_statuses() just won't work without a main loop (this test passed incorrectly before). Fixes: https://bugs.launchpad.net/bugs/1398813.

Approved by Pawel Stolowski, PS Jenkins bot.