lp:~tyhicks/ecryptfs/rewrap-passphrase-cleanups

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ecryptfs at revision 779

eCryptfs: Pending requested 2013-06-27

Diff: 65 lines (+19/-6)

2 files modified

debian/changelog (+5/-0)
src/utils/ecryptfs_rewrap_passphrase.c (+14/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

782. By Tyler Hicks on 2013-06-27

Fix coding style violation due to lack of whitespace

781. By Tyler Hicks on 2013-06-27

Limit scope of new_wrapping_passphrase2

Since new_wrapping_passphrase2 is only initialized and used inside of the
interactive mode block, limit its scope to that block. Otherwise, someone may
try to use it outside of that block in the future and inadvertently cause a
segfault if the pointer was never properly initialized.

780. By Tyler Hicks on 2013-06-27

Remove unnecessary strlen()s and use strcmp()

strlen(), like strcmp(), requires that the strings be NULL terminated. So this:

strlen(str1)
strlen(str2)
strncmp(str1, str2, strlen(str1))

is the complex form of this:

strcmp(str1, str2)

779. By Tyler Hicks on 2013-06-27

* src/utils/ecryptfs_rewrap_passphrase.c:
  - Handle errors when interactively reading the new wrapping passphrase
    and the confirmation from stdin. Fixes a segfault (invalid memory read)
    in ecryptfs-rewrap-passphrase if there was an error while reading either
    of these passphrases.

778. By Tyler Hicks on 2013-06-11

* configure.ac: Add libtool versioning instructions for libecryptfs

777. By Tyler Hicks on 2013-06-08

* src/libecryptfs/decision_graph.c, src/libecryptfs/key_management.c,
  src/libecryptfs/main.c, src/libecryptfs/module_mgr.c, src/utils/io.c,
  src/utils/mount.ecryptfs_private.c, tests/kernel/inotify/test.c,
  tests/kernel/trunc-file/test.c, tests/userspace/wrap-unwrap/test.c:
  - Fixed a pile of minor bugs (memory leaks, unclosed file descriptors,
    etc.) mostly in error paths

776. By Dustin Kirkland  on 2013-05-08

* src/utils/ecryptfs-setup-swap: LP: #1172014
  - write crypttab entry using UUID

775. By Dustin Kirkland  on 2013-03-13

* src/libecryptfs/ecryptfs-stat.c, tests/kernel/extend-file-
  random/test.c, tests/kernel/inode-race-stat/test.c,
  tests/kernel/trunc-file/test.c:
  - Fixed some 32 bit build warnings

774. By Tyler Hicks on 2013-03-11

* doc/manpage/ecryptfs.7:
  - adjust man page text to avoid confusion about whether the interactive
    mount helper takes a capital 'N' for the answer to y/n questions
    (LP: #1130460)

773. By Nobuto Murata on 2013-02-20

[ Nobuto MURATA ]
* fix an empty update-notifier window (LP: #1107650)
  - changes made in Rev.758 was incomplete