lp:~thomas-voss/media-hub/decouple-player-skeleton-and-implementation

Branch merges

Propose for merging

1 branch dependent on this one.

Merged into lp:media-hub at revision 125

PS Jenkins bot: Approve (continuous-integration) on 2015-03-12

Jim Hodapp (community): Needs Fixing (code) on 2014-12-08

Diff: 620 lines (+245/-112)

5 files modified

src/core/media/null_track_list.h (+114/-0)
src/core/media/player_implementation.cpp (+101/-81)
src/core/media/player_implementation.h (+8/-10)
src/core/media/player_skeleton.h (+13/-15)
src/core/media/service_implementation.cpp (+9/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

121. By Thomas Voß on 2015-03-12

* debian/control:
  - Removing pre-depends that are not required
  - Bumping standards-version to 3.9.6
[ Ricardo Salveti de Araujo ]
* Migrating tests to use ogg instead of mp3/avi removed:
  tests/h264.avi tests/test.mp3 added: tests/test-audio-1.ogg
  tests/test-video.ogg tests/test.mp3 renamed: tests/test.ogg =>
  tests/test-audio.ogg

120. By Thomas Voß on 2015-03-05

Move handling of a dying client to its own thread to prvent from deadlocks.

119. By Thomas Voß on 2015-03-04

Merge prereq branch.

118. By Thomas Voß on 2015-02-27

Merge prereq branch.

117. By Thomas Voß on 2015-01-29

Merge prereq branch.

116. By Thomas Voß on 2015-01-26

[ Jim Hodapp ]
* Error reporting all the way up to the app level from the playbin
  pipeline.
[ Ubuntu daily release ]
* New rebuild forced
[ Jim Hodapp ]
* Don't auto-resume playback of videos after a phone call ends. (LP:
  #1411273)
[ Ubuntu daily release ]
* New rebuild forced
[ Ricardo Salveti de Araujo ]
* service_implementation: adding debug for call started/ended signals.
  Make sure account and connection are available when setting up
  account manager (patch from Gustavo Boiko). call_monitor: don't
  check caps when hooking up on/off signals, until bug 1409125 is
  fixed. Enable parallel building . (LP: #1409125)
[ Jim Hodapp ]
* Pause playback when recording begins. (LP: #1398047)
[ Ricardo Salveti de Araujo ]
* call_monitor.cpp: waiting for bridge to be up, and also protecting
  the on_change call (LP: #1408137)

115. By Thomas Voß on 2014-12-15

Address reviewer comments.

114. By Thomas Voß on 2014-12-15

[ Jim Hodapp ]
* Resubmitting with prerequisite branch (LP: #1331041)
[ Justin McPherson ]
* Resubmitting with prerequisite branch (LP: #1331041)

113. By Thomas Voß on 2014-12-01

Decouple PlayerSkeleton and PlayerImplementation by making PlayerImplementation being
able to inherit from arbitrary base classes, as long as they provide the set of properties and signals defined by media::Player.

Adjust the implementation to account for decoupling.

112. By Thomas Voß on 2014-12-01

Decouple the ServiceSkeleton from the ServiceImplementation by introducing a common interface media::KeyedPlayerStore for storing running Player sessions indexed by the Player::Key.
Provide a default implementation HashedKeyedPlayerStore relying on a hash map for keeping track of player instances.
Adjust implementation to account for ServiceImplementation no longer inheriting from ServiceSkeleton.