lp:~stolowski/unity-scopes-api/remote-scopes-partner-id

Created by Paweł Stołowski and last modified
Get this branch:
bzr branch lp:~stolowski/unity-scopes-api/remote-scopes-partner-id
Only Paweł Stołowski can upload to this branch. If you are Paweł Stołowski please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Paweł Stołowski
Project:
unity-scopes-api
Status:
Merged

Recent revisions

561. By Paweł Stołowski

Moved default partner-id path to a static const. Use partner-id value with space to test percent-encoding.

560. By Paweł Stołowski

Also test missing partner id.

559. By Paweł Stołowski

Fix.

558. By Paweł Stołowski

Use unity::util::read_text_file()

557. By Paweł Stołowski

Extended SmartScopesClient test to check user agent string for remote-scopes call.

556. By Paweł Stołowski

Send /custom/partner-id with UserAgent header when requesting remote scopes.

555. By Marcus Tomlinson

Added support for IsAggregator scope .ini option.

Approved by PS Jenkins bot, Michi Henning.

554. By Michi Henning

Changed run_scope() to not create a separate run time up-front just so it can
push the state notification when registry when the scope finishes. This has
two advantages:

- We don't create an extra eleven threads that hang around and do nothing for the
  entire life time of the scope.

- We don't create two run times with the same name (as was happening previously).
  The run time IDs must be unique because they are used to derive other things
  that must be unique, such as socket names and log file names. In particular,
  the duplicate run time IDs caused the log file to get corrupted.

This solution is better than what we had, but still sub-optimal because we are still creating a separate run time at the end just so we can tell the registry that the scope has stopped. It would be better to bury these notifications in the middleware, where we can take short-cuts without all the overhead of outgoing thread pools and the like.

Also deprecated the run_scope() overload that takes a Runtime.ini param. That one was not needed, and not called by anyone (including the Go implementation).

We need to remember to strip this method from Runtime next time we do an ABI incompatible release.

Stripped out a bunch of redundant "mutable" in RuntimeImpl.h.

Approved by Marcus Tomlinson, PS Jenkins bot.

553. By Michi Henning

Generated convenience header wasn't generating #pragma once. Fixes: https://bugs.launchpad.net/bugs/1385360.

Approved by PS Jenkins bot, Marcus Tomlinson.

552. By Marcus Tomlinson

* Update the accounts we already know about when refresh_service_statuses() is called.

* Remove the refresh_services_no_main_loop test as refresh_service_statuses() just won't work without a main loop (this test passed incorrectly before). Fixes: https://bugs.launchpad.net/bugs/1398813.

Approved by Pawel Stolowski, PS Jenkins bot.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:unity-scopes-api
This branch contains Public information 
Everyone can see this information.