lp:~robru/gwibber/locked-login-refactor

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~barry/gwibber/py3 at revision 1449

Barry Warsaw: Pending requested 2012-10-09

Diff: 183 lines (+39/-59)

5 files modified

gwibber/gwibber/protocols/flickr.py (+5/-17)
gwibber/gwibber/protocols/foursquare.py (+8/-21)
gwibber/gwibber/protocols/twitter.py (+5/-18)
gwibber/gwibber/tests/test_flickr.py (+1/-1)
gwibber/gwibber/utils/base.py (+20/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1449. By Robert Bruce Park on 2012-10-09

Promote _locked_login to Base class.

This method had way more shared code between plugins than I'd
anticipated, so I've promoted it to the Base class, and now subclasses
only need to implement the much simpler self._whoami method that does
the actually-protocol-specific stuff.

Keep in mind that any subclass is still free to override
Base._locked_login in the event that a future plugin does actually
require some different behavior here, but so far Facebook, Twitter,
Identica, Flickr, and Foursquare all work as-is.

No tests even needed to be modified (except for a fixed string typo)
because our API is just that good ;-)

1448. By Barry Warsaw on 2012-10-05

Merge lp:~robru/gwibber/fix-rate-limiter

Thanks!

1447. By Barry Warsaw on 2012-10-05

Identi.ca plugin has been ported.

1446. By Barry Warsaw on 2012-10-05

Merged lp:~robru/gwibber/identica. Did some reformatting for style and line
lengths, fixed some pyflakes warnings, and added a test for the new identica
time format.

1445. By Barry Warsaw on 2012-10-05

Merge lp:~robru/gwibber/twitter, with some stuff from barry.

1444. By Barry Warsaw on 2012-09-25

Trunk merge

1443. By Barry Warsaw on 2012-09-25

Provide a better way of distinguishing public features, by using the @feature
decorator on such methods.

Base class gets a get_features() classmethod to return the list of strings
naming the features.

Add tests.

1442. By Barry Warsaw on 2012-09-25

lp:~robru/gwibber/get_tokens refactoring _get_access_token() to the base class.

1441. By Barry Warsaw on 2012-09-21

Merge lp:~robru/gwibber/foursquare-fixup for a few defaults.

1440. By Barry Warsaw on 2012-09-21

Merge lp:~robru/gwibber/publish-fixup-real which now gets the account id for
_publish() from self instead of passing it in as an argument.