lp:~robru/gwibber/dee

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~barry/gwibber/py3 at revision 1433

Ken VanDine: Pending requested 2012-09-18

Barry Warsaw: Pending requested 2012-09-18

Diff: 2162 lines (+327/-1550)

21 files modified

gwibber/gwibber/main.py (+3/-13)
gwibber/gwibber/service/dispatcher.py (+2/-2)
gwibber/gwibber/service/messages.py (+0/-47)
gwibber/gwibber/service/searches.py (+0/-87)
gwibber/gwibber/service/streams.py (+0/-93)
gwibber/gwibber/storage/messages.py (+0/-172)
gwibber/gwibber/storage/searches.py (+0/-63)
gwibber/gwibber/storage/streams.py (+0/-68)
gwibber/gwibber/testing/com.Gwibber.Messages.service.in (+0/-3)
gwibber/gwibber/testing/com.Gwibber.Searches.service.in (+0/-3)
gwibber/gwibber/testing/com.Gwibber.Streams.service.in (+0/-3)
gwibber/gwibber/testing/dbus.py (+0/-3)
gwibber/gwibber/testing/service.py (+1/-48)
gwibber/gwibber/tests/test_account.py (+5/-12)
gwibber/gwibber/tests/test_dbus.py (+0/-237)
gwibber/gwibber/tests/test_model.py (+39/-0)
gwibber/gwibber/tests/test_protocols.py (+95/-0)
gwibber/gwibber/tests/test_storage.py (+0/-688)
gwibber/gwibber/utils/account.py (+7/-6)
gwibber/gwibber/utils/base.py (+66/-2)
gwibber/gwibber/utils/model.py (+109/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1447. By Robert Bruce Park on 2012-09-19

Add a helpful comment.

1446. By Robert Bruce Park on 2012-09-19

Rename some things to indicate that they are private members.

1445. By Robert Bruce Park on 2012-09-19

Avoid regex in order to improve readability.

1444. By Robert Bruce Park on 2012-09-19

Part two of the cleanup based on barry's review.

a) SharedModel is now mocked in the tests so that we are not dumping
   test data into the live SharedModel.

b) Each test is broken down into more bitesize units for easier
   understanding when something goes wrong.

1443. By Robert Bruce Park on 2012-09-19

Part one of cleanup based on barry's review.

a) Stop iterating over the SharedModel, because that's stupidly slow
in practise.

b) cache the output of strip(), making the performance of _publish
O(1) instead of O(n)

1442. By Robert Bruce Park on 2012-09-18

Looks like I didn't rip out enough old crufty stuff last time.

1441. By Robert Bruce Park on 2012-09-18

Add a publish_lock to avoid race conditions.

We are checking for duplicates first, and then appending new rows later,
which creates a race condition in between (eg, some other thread can easily
insert a duplicate row after we find that there are no duplicates present, but
before we get around to appending our own row).

This makes duplicate checking / row appends atomic.

1440. By Robert Bruce Park on 2012-09-18

Tweak the return value logic in Base._publish.

Also stop hard-coding column index numbers.

1439. By Robert Bruce Park on 2012-09-18

Schema fixup, plus working de-duplication logic.

The de-dup logic is modelled very closely on the way libgwibber does
it in Vala, but now we're doing it right at the source before
libgwibber even gets there. Three cheers for efficiency!

1438. By Robert Bruce Park on 2012-09-18

Test that we can get the message back from the SharedModel, too.