lp:~robru/gwibber/accounts-fixup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~barry/gwibber/py3 at revision 1438

Barry Warsaw: Needs Fixing on 2012-09-21

Diff: 630 lines (+122/-104)

13 files modified

gwibber/gwibber/protocols/flickr.py (+9/-12)
gwibber/gwibber/protocols/foursquare.py (+8/-8)
gwibber/gwibber/service/dispatcher.py (+2/-3)
gwibber/gwibber/testing/helpers.py (+11/-3)
gwibber/gwibber/testing/mocks.py (+1/-1)
gwibber/gwibber/tests/test_account.py (+21/-28)
gwibber/gwibber/tests/test_authentication.py (+9/-6)
gwibber/gwibber/tests/test_flickr.py (+9/-10)
gwibber/gwibber/tests/test_foursquare.py (+5/-5)
gwibber/gwibber/tests/test_protocols.py (+2/-6)
gwibber/gwibber/utils/account.py (+35/-14)
gwibber/gwibber/utils/authentication.py (+3/-3)
gwibber/gwibber/utils/base.py (+7/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1446. By Robert Bruce Park on 2012-09-21

Abolish Account.config and upgrade all it's members to instance attributes.

1445. By Robert Bruce Park on 2012-09-21

Rebased onto barry's updated branch, fixup Base._account and Account.id.

All tests pass.

1444. By Robert Bruce Park on 2012-09-21

Ok, for real this time, there are NO MORE things using account['dict_key'] syntax.

I confirmed it with grep -R this time ;-)

1443. By Robert Bruce Park on 2012-09-21

Fix up some tests that were still testing against dict behavior.

1442. By Robert Bruce Park on 2012-09-20

Fixup some access token stuff that got lost in the shuffle.

1441. By Robert Bruce Park on 2012-09-20

And Accounts no longer inherits from dict!

1440. By Robert Bruce Park on 2012-09-20

Consolidate Account.global_id with Account['id'] and update tests accordingly.

1439. By Robert Bruce Park on 2012-09-20

Remove 'auth' from the Account dict and update all tests accordingly.

1438. By Robert Bruce Park on 2012-09-20

Duplicate Account class dict entries as instance attributes, too.

This is the first step in a transitional process of weaning the
Account class off it's dict inheritance. Now that the information is
duplicated in both places, I'll slowly change all other code and tests
to get the information from the new attributes, and then after that's
all done we can drop the dict entirely.

1437. By Robert Bruce Park on 2012-09-20

Rename Base.account to Base._account, to not interfere with public methods.