lp:~robru/friends/replies

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:friends at revision 28

Ken VanDine: Pending requested 2012-10-25

Diff: 398 lines (+101/-43)

10 files modified

friends/main.py (+6/-0)
friends/protocols/facebook.py (+22/-13)
friends/tests/test_account.py (+2/-2)
friends/tests/test_avatars.py (+3/-2)
friends/tests/test_facebook.py (+48/-12)
friends/tests/test_foursquare.py (+1/-1)
friends/tests/test_model.py (+2/-2)
friends/tests/test_twitter.py (+4/-4)
friends/utils/avatar.py (+13/-6)
friends/utils/model.py (+0/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1066105: plugins are not storing avatar data from services into sharedmodel.	High	Fix Released
Bug #1066165: sharedmodel schema needs to be refined.	Medium	Fix Released

Link a bug report

Related blueprints

31. By Robert Bruce Park on 2012-10-25

Invoke the avatar expiry logic from main.py

Also fix up a bunch of test failures.

30. By Robert Bruce Park on 2012-10-25

Shorter log message for avatar downloading.

29. By Robert Bruce Park on 2012-10-25

Access token no longer necessary.

28. By Robert Bruce Park on 2012-10-25

Increase efficiency in avatar downloading.

Previously, we had to send a request to find out the URL, and the we
had to send another request to download the URL; I've streamlined that
now to just construct the URL magically, and then send a single query
direct for the avatar (unless it is cached).

27. By Robert Bruce Park on 2012-10-25

Implement avatar logic for Facebook.

Now for each published message, we query facebook for the avatar url
of the message's sender, and then we download that avatar into the
cache (if necessary).

26. By Robert Bruce Park on 2012-10-25

Drop the 'comments' 'as' field from the model schema.

Facebook's replies have been promoted to top-level comments in the
model. Instead of appearing in the 'messages' stream, there is now a
new set of streams in the format of 'reply_to/*' where * is the
message_id that is being replied to.

This commit also fixes up all the associated test breakages, with some
new test coverage of the new behavior.

25. By Robert Bruce Park on 2012-10-24

Merged lp:~cjcurran/friends/facebook-contacts.

Some style/whitespace cleanup, but also some test fixes too.

24. By Robert Bruce Park on 2012-10-24

Workaround for a bug in DeeModel.insert_sorted.

Apparently insert_sorted can't figure out where in an empty Model to
sortedly insert a new row, so we need to check for that and use
Model.append instead.

This commit also has a bit of logic in place to only do the check
once, and then once we're confident that there is actually at least
one row in the model, it replaces itself with Model.insert_sorted
directly so that it can be called much more efficiently during the
ongoing operation of the program.

23. By Robert Bruce Park on 2012-10-24

Also mock the _seen_ids dict.

22. By Robert Bruce Park on 2012-10-24

Get better about resetting state between tests.