lp:~reedobrien/charmworld/es-migration

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charmworld at revision 512

Juju Gui Bot: Approve (continuous-integration) on 2014-05-20

Brad Crittenden (community): Approve on 2014-05-20

Diff: 370 lines (+281/-41)

5 files modified

charmworld/migrations/versions/027_use_ngrams.py (+35/-0)
charmworld/migrations/versions/tests/__init__.py (+1/-0)
charmworld/migrations/versions/tests/data/migration_027.py (+166/-0)
charmworld/migrations/versions/tests/test_migrations.py (+79/-4)
charmworld/search.py (+0/-37)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1314239: search should ngram index charm and bundle names for search

High

Fix Released

Link a bug report

Related blueprints

517. By Reed O'Brien on 2014-05-20

Assuages stylistic deviations.

516. By Reed O'Brien on 2014-05-20

Remove unused bits of the exists in index helper method.

515. By Reed O'Brien on 2014-05-20

Actually make the migration do reindexing.

514. By Reed O'Brien on 2014-05-19

Add tests for the ngrams es migration.

Hopefully this finally fixes Bug #1314239 satisfactorily.

While working on getting the tests to prove things right I realized that
the mappings in the index creation bit were redundant to the ones in
ElasticSearchClient.put_mapping. Therefore I removed them.

Previous attempt to deploy failed because there was no migration. Now, the
migration should run automagically when deployed by the bot.

This commit also captures the old mapping so we can test against it.

513. By Reed O'Brien on 2014-05-19

make es upgrade test more comprehensive

512. By Reed O'Brien on 2014-05-16

add migration for es and a test for the migration.

511. By Brad Crittenden on 2014-05-15

Allow local charm ingestion.

To bin/ingest-queued the new option --local-repo has been added. Give the
path to a parent directory and all subdirectories that are Bazaar branches
will be ingested as charms.

Fixes bug 1319140 where the --debug option wasn't declared in the correct
place, causing bin/enqueue to die. While the work of that script is now a
part of bin/ingest-queued it still has utility as a free-standing script and
is kept.

https://codereview.appspot.com/98280043/

R=jcsackett. Fixes: https://bugs.launchpad.net/bugs/1319140.

Approved by Juju Gui Bot.

510. By Reed O'Brien on 2014-05-14

Fixes a destructive test in Bug #1317567. Fixes: https://bugs.launchpad.net/bugs/1317567.

Approved by Juju Gui Bot, Brad Crittenden.

509. By Reed O'Brien on 2014-05-14

adds ngrams as multifield index to name. skips destructive test -- see Bug #1317567.

Approved by Juju Gui Bot, Richard Harding, j.c.sackett.

508. By Brad Crittenden on 2014-05-07

Include annotations in bundle search results.

The previous attempt at this problem was flawed in that API call for
getting bundles directly pulls from Mongo while search?text= and
search/interesting get results from ElasticSearch.

QA:

Load up some bundles with annotations:

bin/ingest-queued --prefix="~charmers/charms/precise/ntp"
bin/ingest-queued --prefix="~bac"

Change juju-gui to point to locally running charmworld:

diff --git a/app/config-debug.js b/app/config-debug.js
index 39daca6..f2c86b6 100644
--- a/app/config-debug.js
+++ b/app/config-debug.js
@@ -32,7 +32,10 @@ var juju_config = {
   // These are the main application config items used and passed down into all
   // SubApps.
   consoleEnabled: true,
+ //charmworldURL: 'https://manage.jujucharms.com/',
+ charmworldURL: 'http://127.0.0.1:2464/',

Run charmworld and juju-gui. In the GUI wait for the initial results to
load. These are the Featured charms and bundles.

Select the rails-scalable bundle. Note the layout in the inspector. Close
the inspector and then drag the bundle (using the name not the icon) to the
canvas. Note that the layout is the same as the preview.

https://codereview.appspot.com/91140045/

R=jcsackett.

Approved by Juju Gui Bot.