lp:~phablet-team/messaging-framework/include-message-when-group-cancelled

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:messaging-framework at revision 59

Tiago Salem Herrmann (community): Approve on 2016-08-26

system-apps-ci-bot: Approve (continuous-integration) on 2016-08-26

Diff: 304 lines (+63/-89)

6 files modified

debian/changelog (+7/-0)
include/messaging/group_manager.h (+8/-11)
include/messaging/qt/tp/text_channel.h (+9/-14)
src/CMakeLists.txt (+1/-0)
src/messaging/group_manager.cpp (+4/-17)
src/messaging/qt/tp/text_channel.cpp (+34/-47)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

61. By Roberto Mier Escandon on 2016-08-26

delay the close to let the events get to the client before the channel is closed

60. By Roberto Mier Escandon on 2016-08-25

updated changelog

59. By Roberto Mier Escandon on 2016-08-25

removed redundant error callbacks for group cancelled. Leave only one callback for any reason

58. By Roberto Mier Escandon on 2016-08-25

Include self handle as member
Remove self handle when group is cancelled by using direct setMember method to trigger needed event
Include initial invitees from group manager after calling group_starter.create_group() instead of using the original ones (this way the plugin could reformat identifiers).

Approved by Tiago Salem Herrmann, system-apps-ci-bot.

57. By Roberto Mier Escandon on 2016-08-24

prevents including self handle amongst handles for add/remove operations in plugin.
This fixes the problem of trying to remove self handle from the server when cancelled the group.

Approved by Tiago Salem Herrmann, system-apps-ci-bot.

56. By Roberto Mier Escandon on 2016-08-23

Fw code modifying Members to use Roles interface so that upper layers receive participants permissions
Also setting roles when added members from the client

NOTE: This MR should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/roles-management/+merge/303265.

Approved by Tiago Salem Herrmann, system-apps-ci-bot.

55. By Roberto Mier Escandon on 2016-08-23

Added creator to the group when created the channel.

NOTE: this branch should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/include-group-creator/+merge/303179.

Approved by Tiago Salem Herrmann, system-apps-ci-bot.

54. By Roberto Mier Escandon on 2016-08-16

Fixes the problem of having the content as string instead of as data. Both types are indeed taken into account now.

Approved by system-apps-ci-bot, Tiago Salem Herrmann.

53. By Roberto Mier Escandon on 2016-08-16

Added flags generic type
Added permissions flags for groups in group_manager, so that every plugin has to fill them with the ones the current user has as participant in the group

NOTE: this MR should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/group-own-permissions/+merge/302308.

Approved by system-apps-ci-bot, Tiago Salem Herrmann.

52. By Roberto Mier Escandon on 2016-08-16

- When cancelling group, do this:
1) remove self handle giving a reason
2) close channel

- Provided an enum of generic reasons for cancelling the group
- Removed not needed on_closed() callback in Chat object.

NOTE: This MRs should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/set-reason-when-cancelling-group/+merge/302508.

Approved by Tiago Salem Herrmann, system-apps-ci-bot.