lp:~nikwen/ubuntu-push/gmail-missed-messages-cleanup-fix-new

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-push/automatic at revision 408

Samuele Pedroni: Approve on 2015-08-13

Diff: 431 lines (+136/-104)

5 files modified

client/service/postal.go (+0/-2)
debian/rules (+2/-2)
messaging/cmessaging/cmessaging.go (+0/-1)
messaging/messaging.go (+32/-49)
messaging/messaging_test.go (+102/-50)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1451510: Gmail messages might be missed after clearing notifications

Undecided

Fix Released

Link a bug report

Related blueprints

416. By Niklas Wenzel on 2015-08-13

Run gofmt

415. By Niklas Wenzel on 2015-08-12

Much better fix, OOP style :)

414. By Niklas Wenzel on 2015-08-12

Fix race condition in unit test

413. By Niklas Wenzel on 2015-08-11

Fix tests

412. By Niklas Wenzel on 2015-08-11

Build fix

411. By Niklas Wenzel on 2015-08-11

Fix issue

410. By Niklas Wenzel on 2015-08-06

Clean up notifciations when calling Clear(), improve test

409. By Niklas Wenzel on 2015-08-06

Fix potentially high memory consumption when nobody calls Tags() and implement TestCleanupInAddNotification

408. By Niklas Wenzel on 2015-07-15

Remove the clean up loop and instead clean up whenever it is needed. This ensures that the notification list is always up to date and fixes an issue where Gmail notifications might be missed due to outdated information about the current state (LP: #1451510). Also includes tests.

407. By Niklas Wenzel on 2015-07-15

Revert the old cleanup fix (r403)