lp:~kissiel/checkbox/sa-in-cbt

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3970

Zygmunt Krynicki (community): Approve on 2015-08-31

Diff: 958 lines (+248/-396)

5 files modified

checkbox-touch/checkbox-touch.qml (+39/-32)
checkbox-touch/components/CheckboxTouchApplication.qml (+4/-4)
checkbox-touch/py/checkbox_touch.py (+135/-327)
checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+33/-30)
plainbox/plainbox/impl/session/assistant.py (+37/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3997. By Maciej Kisielewski on 2015-08-31

checkbox-touch: upgrade docstrings

Some of the functions have laconic docstrings as they serve only as a bridge to
functionality served by session assistant.

Signed-off-by: Maciej Kisielewski <email address hidden>

3996. By Maciej Kisielewski on 2015-08-31

checkbox-touch: fix PEP8 issues

Signed-off-by: Maciej Kisielewski <email address hidden>

3995. By Maciej Kisielewski on 2015-08-31

checkbox-touch: remove import of no longer used modules

Signed-off-by: Maciej Kisielewski <email address hidden>

3994. By Maciej Kisielewski on 2015-08-31

checkbox-touch: remove unnecessary methods

Signed-off-by: Maciej Kisielewski <email address hidden>

3993. By Maciej Kisielewski on 2015-08-31

checkbox-touch:[move2SA] use SA in clear_session

Signed-off-by: Maciej Kisielewski <email address hidden>

3992. By Maciej Kisielewski on 2015-08-31

plainbox:session:assistant: add finalize_session method

This patch adds a way to end the testing session. Call to finalize_session will
remove 'incomplete' flag, and make a checkpoint in the storage, so the session
won't be considered a candidate for resuming.

Signed-off-by: Maciej Kisielewski <email address hidden>

3991. By Maciej Kisielewski on 2015-08-31

plainbox:session:assistant: require select_test_plan after resume

This patch changes usage expectations of session assistant to enforce calling
'select_test_plan' after session got resumed.

Signed-off-by: Maciej Kisielewski <email address hidden>

3990. By Maciej Kisielewski on 2015-08-31

checkbox-touch: move embedded providers stuff to CBTApp.__init__

This patch changes when and where info about embedded providers directory is
propagated from QML to the python side.
Previously this path was pushed when starting or resuming session. When using
session assistant we need to load providers earlier, before we start checking
whether the session is resumable, which is one step before resuming or starting
the session.
This also makes the code cleaner, as we don't need to push this variable in
multiple calls. Note that this 'variable' is quite constant throughout the
lifetime of the app, as its value is read once from the setting.json.

Signed-off-by: Maciej Kisielewski <email address hidden>

3989. By Maciej Kisielewski on 2015-08-31

plainbox:session:assistant: allow export_to_file call in 'normal' state

Signed-off-by: Maciej Kisielewski <email address hidden>

3988. By Maciej Kisielewski on 2015-08-31

plainbox:session:assistant: correct UsageExpectations after session is started

This patch makes get_session_id and get_session_dir allowed after
start_new_session is called()

Signed-off-by: Maciej Kisielewski <email address hidden>