lp:~kissiel/checkbox/fix-mem-inflation

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3992

Zygmunt Krynicki (community): Approve on 2015-09-07

Diff: 12 lines (+1/-1)

1 file modified

checkbox-touch/components/CommandOutputPage.qml (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1490533: Some shell jobs are causing Checkbox Converged to crash

Critical

Fix Released

Link a bug report

Related blueprints

3992. By Maciej Kisielewski on 2015-09-07

checkbox-touch: fix horrible mem usage when job prints stuff

CommandOutput page used a buffer that was filled with the strings that job's
command printed and periodically timer synced that output onto the text area.
As the buffer qml's "property string" was used. This somehow broke garbage
collecting and the strings were never freed from memory. By changing the type
to 'property var' fixed all problems.
Why?
I don't know.
Here: http://paste.ubuntu.com/12310269/ is the code I did to pinpoint where/how
the problem may be solved. If you want to reproduce the bug, in the pastebinned
code change the type of bufferedIO from 'var' to 'string'.

Fixes: https://bugs.launchpad.net/checkbox-converged/+bug/1490533

Signed-off-by: Maciej Kisielewski <email address hidden>

3991. By Maciej Kisielewski on 2015-09-07

"automatic merge of lp:~kissiel/checkbox/make-latch-buttons-disabled-while-latched/ by tarmac [r=zyga][bug=][author=kissiel]"

3990. By Maciej Kisielewski on 2015-09-07

"automatic merge of lp:~kissiel/checkbox/transports-in-cc/ by tarmac [r=sylvain-pineau][bug=][author=kissiel]"

3989. By Sylvain Pineau on 2015-09-07

"automatic merge of lp:~sylvain-pineau/checkbox/sru-with-sa/ by tarmac [r=sylvain-pineau,zyga][bug=][author=sylvain-pineau]"

3988. By Pierre Equoy on 2015-09-07

"automatic merge of lp:~pierre-equoy/checkbox/fix-1484872-env-variables-forced-to-non-international-in-differential-env/ by tarmac [r=zyga][bug=1484872][author=pierre-equoy]"

3987. By Po-Hsu Lin on 2015-09-07

"automatic merge of lp:~cypressyew/checkbox/tb-time/ by tarmac [r=zyga][bug=1471945][author=cypressyew]"

3986. By Po-Hsu Lin on 2015-09-07

"automatic merge of lp:~cypressyew/checkbox/gz-extension/ by tarmac [r=zyga][bug=1484042][author=cypressyew]"

3985. By Launchpad Translations on behalf of checkbox-dev on 2015-09-05

Launchpad automatic translations update.

3984. By Zygmunt Krynicki on 2015-09-04

"automatic merge of lp:~zyga/checkbox/sa-pep8/ by tarmac [r=kissiel][bug=][author=zyga]"

3983. By Po-Hsu Lin on 2015-09-04

"automatic merge of lp:~cypressyew/checkbox/reorder-pmtest/ by tarmac [r=zyga][bug=1492107][author=cypressyew]"