lp:~jjacobs/methanal/slug-inputs

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:methanal

Tristan Seligmann: Approve on 2009-10-09

Diff: 760 lines

9 files modified

methanal/js/Methanal/Tests/DOMUtil.js (+1/-1)
methanal/js/Methanal/Tests/TestUtil.js (+8/-8)
methanal/js/Methanal/Tests/TestValidators.js (+2/-2)
methanal/js/Methanal/Tests/TestView.js (+217/-39)
methanal/js/Methanal/Tests/Util.js (+2/-2)
methanal/js/Methanal/Util.js (+3/-3)
methanal/js/Methanal/View.js (+154/-4)
methanal/js/Methanal/Widgets.js (+1/-1)
methanal/view.py (+50/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #440958: No widget for filtering text input or pre-populating fields

Low

Fix Released

Link a bug report

Related blueprints

101. By Jonathan Jacobs on 2009-10-09

Call Nevow.Athena.Widget.removeChildWidget when cleaning up testControls.

100. By Jonathan Jacobs on 2009-10-09

Refactor testControl to remove the need to override it.

99. By Jonathan Jacobs on 2009-10-09

Cosmetic tweaks.

98. By Jonathan Jacobs on 2009-10-09

Remove trailing whitespace from Javascript.

97. By Forrest Aldridge on 2009-10-08

Fixed PrePopulatingTextInput's onchange and onkeyup event handlers to pass
    the input node, rather than the widget node, to the target control's
    corresponding event handlers.

Removed superfluous 'node' parameter from FilteringTextInput.filter() and
    using self.inputNode instead.

Simplified FilteringTextInput's docstring in the Python code.

All unit tests now passed.

96. By Forrest Aldridge on 2009-10-07

Addressed code review points:

 1. Fixed.
 2. Fixed.
 3. Fixed.
 4. No, they don't. Fixed.
 5. There was a reason, but not a good one. Fixed.
 6. Implementation fixed and test case added.
 7. Fixed.
 8. Agreed. Fixed.
 9. Fixed.
10. Nope. Fixed.
11. Fixed.
12, 13. Ooops. Fixed.
14. Fixed.
15. Sorry, irrelevant. Fixed.
16. Fixed.
17. Fixed.
18. No good reason. Fixed.

One unit test still fails, though I think it is a problem with my unit test
    code. Feedback on this would be appreciated.

95. By Forrest Aldridge on 2009-10-06

Added unit tests for new controls, and made the necessary fixes to make
    all tests pass. Huzzah for unit testing.

94. By Forrest Aldridge on 2009-10-05

Merged forward.

93. By Forrest Aldridge on 2009-10-02

Addressed all code review issues. Almost a complete rewrite of all
    functionality.

Changed SlugInput to FilteringTextInput, a general version of the same
    functionality that subclasses TextInput directly instead of FormInput.

Changed SlugifyingInput to PrePopulatingTextInput, a general version of the same
    functionality.

Removed VerifiedPasswordInput and will create a new branch for it.

Removed an uneccessary class (TogglingCheckboxInput) that I hacked together
    before I realized the dependency system existed.

Improved all Python and JavaScript docstrings.

TODO: add unit tests for all new classes.

92. By Forrest Aldridge on 2009-10-02

Merged forward.