lp:~jamesodhunt/upstart/remove-basic-user-sessions

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:upstart at revision 1431

Colin Watson (community): Approve on 2013-01-30

Steve Langasek: Needs Fixing on 2013-01-29

Diff: 2363 lines (+321/-1503)

14 files modified

ChangeLog (+48/-0)
dbus/Upstart.conf (+36/-6)
init/control.c (+135/-37)
init/job.c (+1/-1)
init/job_class.c (+9/-32)
init/job_process.c (+2/-91)
init/man/init.5 (+16/-53)
init/session.c (+50/-168)
init/session.h (+12/-14)
init/state.h (+3/-3)
init/tests/test_conf.c (+2/-0)
init/tests/test_state.c (+4/-7)
util/tests/test_initctl.c (+3/-0)
util/tests/test_user_sessions.sh (+0/-1091)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1432. By James Hunt on 2013-01-30

* init/control.c: Comments.

1431. By James Hunt on 2013-01-30

* init/control.c:
  - Typos.
  - Improved uid checks.
  - Replaced direct call to control_get_origin_uid() with call to new
    control_check_permission() (as early as possible) for clarity and
    to confine policy to one location.
  - control_set_log_prioity(): Added missing call to
    control_check_permission().
  - control_get_origin_uid(): Check message contents before allowing
    D-Bus calls.
* init/control.h: Added missing prototypes.

1430. By James Hunt on 2013-01-29

* init/control.c: More careful uid checking.

1429. By James Hunt on 2013-01-25

* util/tests/test_user_sessions.sh: Removed.
* init/man/init.5: Updated to reflect removal of user jobs.

1428. By James Hunt on 2013-01-25

* Sync with lp:upstart.

1427. By James Hunt on 2013-01-25

* init/control.c:
  - control_reload_configuration(): Added missing permission checks.
  - control_emit_event_with_file(): Added missing permission checks.
  - Added calls to new function control_get_origin_uid() to allow
    D-Bus methods to be policed by filtering on uid, rather than
    relying on the same information that used to be stored in the
    old Session object.
* init/job.c: Typo.
* init/job_class.c:
  - job_class_new(): Removed user elements from session code.
  - job_class_serialise(): Comments.
  - job_class_deserialise(): Comments.
* init/job_process.c: job_process_spawn(): Removed user session
  handling.
* init/session.c: Removed user session handling since it is
  about to be replaced by the ability to run Upstart as a
  non-privileged user (aka a 'Session Init').
* init/session.h: Updated prototypes.
* init/state.h: Comments.
* init/tests/test_conf.c: test_source_reload_job_dir(): Added missing
  check.
* init/tests/test_state.c:
  - session_diff(): Removed user check.
  - Updated all calls to session_new().
* util/tests/test_initctl.c: test_notify_disk_writeable(): Ensure this
  test is not run as root.

1426. By James Hunt on 2013-01-21

* init/log.c:log_clear_unflushed(): Simplify asserts.

1425. By James Hunt on 2013-01-15

* init/log.c:
  - log_clear_unflushed(): Correct remote_closed assertion to handle
    early-job-logging scenario where a job satisfies both of the
    following conditions:
    - ends before the log directory becomes writeable.
    - has spawned one or more processes that continue to run after the
      job itself has exited and which produce output before the log
      directory becomes writeable.
    (LP: #1096531).

1424. By James Hunt on 2013-01-11

* Merge of lp:~stgraber/upstart/upstart-event-bridge-typo.

1423. By James Hunt on 2013-01-08

Merge of lp:~xnox/upstart/overrides.