lp:~jamesodhunt/upstart/bug-1222705-reprise

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:upstart at revision 1656

Colin Watson (community): Approve on 2014-07-16

Dimitri John Ledkov: Needs Information on 2014-07-16

Steve Langasek: Pending (please review memoves against (potentially) nih_alloced char** array) requested 2014-07-16

Diff: 304 lines (+45/-86)

3 files modified

ChangeLog (+8/-0)
init/environ.c (+12/-14)
init/tests/test_environ.c (+25/-72)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1222705: init assert failure: alloc.c:633: Assertion failed in nih_unref: ref != NULL

High

Confirmed

Link a bug report

Related blueprints

1658. By James Hunt on 2014-07-16

* init/environ.c: environ_remove(): Style tweak courtesy of cjwatson's
  review.

1657. By James Hunt on 2014-07-16

* init/environ.c: environ_remove(): Shrink memory to fit what we're
  actually using.
* init/tests/test_environ.c: test_remove(): Remove now-invalid ENOMEM
  checks.

1656. By James Hunt on 2014-07-16

* init/environ.c: environ_remove():
  - Ensure removed entry is deref'd (LP: #1222705).
  - Avoid recreating array.
* init/tests/test_environ.c: test_remove(): Add checks to ensure
  removed entry freed as expected.

1655. By Dimitri John Ledkov on 2014-07-14

fix pid

1654. By Dimitri John Ledkov on 2014-07-14

Allow either result

1653. By Dimitri John Ledkov on 2014-07-13

clean up test & call job_process_handler

1652. By Dimitri John Ledkov on 2014-07-12

Actually make WITHOUT_JOB_PROCESS to be without job_process_handler.

1651. By Dimitri John Ledkov on 2014-07-12

Split 'with no such file' test into two scenarios - read handler or job_process_handler getting called first.

1650. By James Hunt on 2014-07-11

* NEWS: Begin new release.

1649. By James Hunt on 2014-07-11

* NEWS: Added missing datestamp.