lp:~colin-king/ecryptfs/coverity-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ecryptfs at revision 791

eCryptfs: Pending requested 2013-10-10

Diff: 88 lines (+24/-11)

3 files modified

src/key_mod/ecryptfs_key_mod_passphrase.c (+7/-6)
src/libecryptfs/main.c (+11/-1)
src/pam_ecryptfs/pam_ecryptfs.c (+6/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

794. By Colin Ian King on 2013-10-10

* don't use strtok to strip off trailing newline
  - Coverity Scan complains that strtok will return a pointer that is
    different to that of mnt which will cause issues when it is free'd. In
    fact, strtok first time around always returns mnt in this case. Anyhow,
    since strtok is a little opaque I reworked it and Coverity is now happy.

793. By Colin Ian King on 2013-10-10

* src/key_mod/ecryptfs_key_mod_passphrase.c
  move file_head allocation to after the passphrase handling so that
  we can avoid messy free'ing of file_head if things go wrong. This change
  fixes a memory leak on file_head.

792. By Colin Ian King on 2013-10-10

* src/pam_ecryptfs/pam_ecryptfs.c
  - no need to check for error return on geteuid and getegid as these
    never fail

791. By Colin Ian King on 2013-10-10

* src/libecryptfs/main.c
  - check for failed shmget before attempting shmat

790. By Colin Ian King on 2013-10-04

* src/libecryptfs/decision_graph.c
  - free param_vals on error handling exits

789. By Colin Ian King on 2013-10-04

* src/utils/mount.ecryptfs.c
  - explicitly ignore mkdir() return

788. By Colin Ian King on 2013-10-04

* src/libecryptfs/cmd_ln_parser.c
  - ensure data is null terminated

787. By Colin Ian King on 2013-10-04

* src/libecryptfs/cmd_ln_parser.c
  fix memory leak on name, the loop is doing multiple mallocs but not
  freeing previos allocations

786. By Colin Ian King on 2013-10-04

* src/pam_ecryptfs/pam_ecryptfs.c:
  - free auth_tok_sig

785. By Colin Ian King on 2013-10-04

* src/pam_ecryptfs/pam_ecryptfs.c
  do not close a negative file descriptor if an open error occurs