lp:~charlesk/keeper/refactor-backup-helper

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:keeper at revision 39

Xavi Garcia (community): Approve on 2016-07-13

Diff: 1396 lines (+637/-429)

19 files modified

debian/keeper.install (+1/-0)
include/helper/backup-helper.h (+18/-19)
include/helper/helper.h (+45/-0)
src/helper/CMakeLists.txt (+2/-2)
src/helper/backup-helper.cpp (+351/-27)
src/helper/exec-tool (+1/-2)
src/helper/helper.cpp (+74/-0)
src/helper/internal/backup-helper-impl.cpp (+0/-202)
src/helper/internal/backup-helper-impl.h (+0/-82)
src/service/keeper-helper.cpp (+6/-3)
src/service/keeper.cpp (+66/-39)
src/service/keeper.h (+4/-8)
src/simple-helper/main.cpp (+18/-11)
src/storage-framework/storage_framework_client.cpp (+1/-1)
src/storage-framework/storage_framework_client.h (+1/-1)
src/tar/main.cpp (+9/-5)
src/util/CMakeLists.txt (+2/-0)
src/util/logging.cpp (+15/-16)
tests/unit/helper/helpers-test.cc (+23/-11)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

60. By Charles Kerr on 2016-07-13

in keeper-tar-creator, sleep briefly if we get an EAGAIN error

59. By Charles Kerr on 2016-07-13

in helpers-test, if the test fails, leave the xdg_data_home artifacts behind so devs can investigate

58. By Charles Kerr on 2016-07-13

in helpers-test, more verbose error logging for checkStorageFrameworkContent()

57. By Charles Kerr on 2016-07-13

in com.canonical.keeper.Helper.StartDownload(), return the right socket

56. By Charles Kerr on 2016-07-13

copyediting

55. By Charles Kerr on 2016-07-13

better cancel detection

54. By Charles Kerr on 2016-07-13

in simple-helper, fix off-by-one error, we weren't sending the string's trailing zero

53. By Charles Kerr on 2016-07-13

these debug logs are impossible to read... clean them up a bit

52. By Charles Kerr on 2016-07-13

argh, another EAGAIN bug in keeper-tar-creator

51. By Charles Kerr on 2016-07-13

cherrypick exec-tool and debian/ fixes from lp:~xavi-garcia-mena/keeper/helper-bash-script-tar-create