lp:~charlesk/keeper/lp-1614764-fix-excess-signal-subscriptions

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:keeper/devel

Xavi Garcia (community): Approve on 2016-08-22

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-08-19

Diff: 277 lines (+91/-64)

4 files modified

src/helper/backup-helper.cpp (+16/-20)
src/service/keeper.cpp (+66/-25)
src/storage-framework/storage_framework_client.cpp (+5/-15)
tests/integration/helpers/helpers-test-failure.cpp (+4/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1614695: BackupHelper tasks will never get marked as cancelled	Medium	In Progress
Bug #1614764: BackupHelper doesn't clean up its signal subscriptions	Medium	In Progress

Link a bug report

Related blueprints

101. By Charles Kerr on 2016-08-19

in the Keeper DBus service, remember to disconnect from StorageClientFramework after we get the signal we wanted

100. By Charles Kerr on 2016-08-19

(copyediting) in storage-framework-client, remove redundant qDebug call

99. By Charles Kerr on 2016-08-19

(copyediting) in storage-framework-client, remove unused #includes

98. By Charles Kerr on 2016-08-19

sync with lp:keeper/devel

97. By Charles Kerr on 2016-08-18

(copyediting) fix whitespace/indentation

96. By Charles Kerr on 2016-08-18

in BackupHelperWritesTooMuch's EXPECT_EQ() calls, put expected on the lhs and actual on the rhs. Also, compare std::strings instead of QStrings so that we get easy debug info of what we expected and what we got

95. By Charles Kerr on 2016-08-18

rename helpers-test-failure.cpp's StartFullTest as BackupHelperWritesTooMuch to differentiate from the other StartFullTest

94. By Charles Kerr on 2016-08-18

since this bug is the reason we stopped processing byte counts in BackupHelperImpl::on_bytes_uploaded(), restore that behavior now

93. By Charles Kerr on 2016-08-18

when BackupHelper gets a new storage framework socket, stop listening to the old one

92. By Charles Kerr on 2016-08-18

Corrected fix for the speed test failures. Fixes: https://bugs.launchpad.net/bugs/1607393.

Approved by unity-api-1-bot, Xavi Garcia.