lp:~charlesk/indicator-sync/lp-1040137

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:indicator-sync/12.10 at revision 13

Lars Karlitski (community): Approve on 2012-09-01

jenkins (community): Approve (continuous-integration) on 2012-08-31

Diff: 392 lines (+211/-46)

3 files modified

src/service/app-menu-item.c (+4/-4)
src/service/sync-service.c (+25/-24)
test/test-client.cpp (+182/-18)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1040137: unit test coverage is low

High

Fix Released

Link a bug report

Related blueprints

51. By Charles Kerr on 2012-08-31

don't clutter up the log with CallIndicatorServiceMethod's false negative.

50. By Charles Kerr on 2012-08-30

don't instantiate an IndicatorService until we get the dbus

49. By Charles Kerr on 2012-08-30

fix r48 wtf

48. By Charles Kerr on 2012-08-30

wait 5 seconds before timing out from no watchers

47. By Charles Kerr on 2012-08-29

poke CI again

46. By Charles Kerr on 2012-08-29

it looks like on CI's system, when we call sync-service's 'Shutdown' method via the bus, the service shuts down so quickly that the response doesn't get sent. Let's test this theory by reducing the severity of our this-method-call-should-receive-a-reply check from an ASSERT_TRUE to an EXPECT_TRUE

45. By Charles Kerr on 2012-08-29

sync with lp:indicator-sync

44. By Charles Kerr on 2012-08-29

add unit tests for the service's 'paused', 'client-count', and 'state' properties

43. By Charles Kerr on 2012-08-29

in sync-service, we don't need the adapter function service_shutdown(), since g_signal_connect_swapped() will do the adapting

42. By Charles Kerr on 2012-08-29

in TearDownServiceProxy(), if the proxy's name is owned by an IndicatorService, ensure it's Shutdown properly