lp:~ahayzen/webbrowser-app/dnd-tabs-001
- Get this branch:
- bzr branch lp:~ahayzen/webbrowser-app/dnd-tabs-001
Branch merges
- Olivier Tilloy: Approve
- system-apps-ci-bot: Pending (continuous-integration) requested
-
Diff: 1879 lines (+1148/-67)23 files modifiedsrc/app/webbrowser/Browser.qml (+156/-27)
src/app/webbrowser/BrowserTab.qml (+19/-2)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+7/-2)
src/app/webbrowser/Suggestions.qml (+1/-1)
src/app/webbrowser/TabComponent.qml (+29/-12)
src/app/webbrowser/TabItem.qml (+2/-2)
src/app/webbrowser/TabsBar.qml (+108/-14)
src/app/webbrowser/TabsList.qml (+2/-2)
src/app/webbrowser/drag-helper.cpp (+134/-0)
src/app/webbrowser/drag-helper.h (+72/-0)
src/app/webbrowser/reparenter.cpp (+124/-0)
src/app/webbrowser/reparenter.h (+46/-0)
src/app/webbrowser/webbrowser-app.cpp (+6/-0)
src/app/webbrowser/webbrowser-app.qml (+33/-3)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+202/-0)
tests/unittests/qml/CMakeLists.txt (+2/-0)
tests/unittests/qml/ReparenterFakeContainer.qml (+40/-0)
tests/unittests/qml/ReparenterFakeTab.qml (+37/-0)
tests/unittests/qml/tst_BrowserTab.qml (+3/-2)
tests/unittests/qml/tst_QmlTests.cpp (+7/-0)
tests/unittests/qml/tst_Reparenter.qml (+114/-0)
tests/unittests/qml/tst_TabsBar.qml (+2/-0)
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 1612 lines (+1080/-47)22 files modifiedpo/webbrowser-app.pot (+24/-20)
src/app/webbrowser/Browser.qml (+129/-4)
src/app/webbrowser/BrowserTab.qml (+20/-3)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+6/-0)
src/app/webbrowser/TabComponent.qml (+22/-10)
src/app/webbrowser/TabsBar.qml (+84/-4)
src/app/webbrowser/TabsList.qml (+2/-2)
src/app/webbrowser/drag-helper.cpp (+100/-0)
src/app/webbrowser/drag-helper.h (+61/-0)
src/app/webbrowser/reparenter.cpp (+94/-0)
src/app/webbrowser/reparenter.h (+45/-0)
src/app/webbrowser/webbrowser-app.cpp (+4/-0)
src/app/webbrowser/webbrowser-app.qml (+48/-2)
tests/autopilot/webbrowser_app/tests/__init__.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+203/-0)
tests/unittests/qml/CMakeLists.txt (+2/-0)
tests/unittests/qml/ReparenterFakeContainer.qml (+40/-0)
tests/unittests/qml/ReparenterFakeTab.qml (+37/-0)
tests/unittests/qml/tst_BrowserTab.qml (+5/-2)
tests/unittests/qml/tst_QmlTests.cpp (+4/-0)
tests/unittests/qml/tst_Reparenter.qml (+120/-0)
Branch information
Recent revisions
- 1552. By Andrew Hayzen
-
* Use deleteLater rather than delete item; otherwise on slower devices such as phones it crashes
* Don't delete the context if it was not removed from the reparenter context store
* Change qml test for reparenter to respect that the delete may take time to happen - 1551. By Andrew Hayzen
-
* Before tab is closed, check if a new tab needs to be generated as the context will disappear
- 1550. By Andrew Hayzen
-
* Use enabled rather than visible on the tabContainer to prevent events being stolen, otherwise chrome disappears when opening new tabs as the locationBarCont
roller. offset doesn't get set - 1549. By Andrew Hayzen
-
* Change keyboard shortcuts to use contentsContainer visibility instead of tabsContainer
- 1545. By Andrew Hayzen
-
* Changed DragHelper to be a QObject and use member initialisation
* Changed Reparenter::createObject to use beginCreate and completeCreate
* Various fixes to reduce warnings under QML tests - 1544. By Andrew Hayzen
-
* Add .dragging property to DragHelper so that drop area shade knows when a drag event is occuring
* Change DragHelper to a singleton
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:webbrowser-app