lp:~aauzi/midori/fix-1179624

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:midori at revision 6202

Cris Dywan: Approve on 2013-06-07

André Auzi: Needs Resubmitting on 2013-06-04

Paweł Forysiuk: Approve on 2013-06-02

Diff: 547 lines (+404/-10)

4 files modified

midori/midori-array.c (+150/-0)
midori/midori-array.h (+7/-0)
midori/midori-browser.c (+15/-4)
panels/midori-bookmarks.c (+232/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1179624: Lack of visual feedback in bookmarks panel

Wishlist

Fix Released

Link a bug report

Related blueprints

6180. By André Auzi on 2013-06-04

Take into account review comments + merge lp:midori

6179. By André Auzi on 2013-06-02

merge lp:midori

6178. By André Auzi on 2013-06-02

Change code style

6177. By André Auzi on 2013-05-31

Remove change in midori_browser_bookmark_open_activate_cb

6176. By André Auzi on 2013-05-31

Merge lp:midori

6175. By André Auzi on 2013-05-31

Complete remove of "app" related code

Take pfor's comments into account: texts simplifications and redundancy
reduced

6174. By André Auzi on 2013-05-31

Fix potential memory leak in:

489 +static KatzeItem*
490 +midori_bookmarks_get_item_at_pos (GtkTreeView *treeview,
491 + gint x, gint y)
492 +{
493 + GtkTreeModel* model = gtk_tree_view_get_model (treeview);
494 + GtkTreePath* path;
495 + GtkTreeIter iter;
496 + KatzeItem* item;
497 +
498 + gtk_tree_view_get_path_at_pos (treeview, x, y,
499 + &path, NULL, NULL, NULL);
500 +
501 + if (!path)
502 + return NULL;
503 +
504 + if (!gtk_tree_model_get_iter (model, &iter, path))
505 + return NULL;
506 +
507 + gtk_tree_model_get (model, &iter, 0, &item, -1);
508 +
509 + gtk_tree_path_free (path); <= can leak if gtk_tree_model_get_iter returned FALSE
510 +
511 + return item;
512 +}

6173. By André Auzi on 2013-05-31

Merge with lp:midori.

1 conflict solved:
 * remove of Open link as web application in link popup context menu

6172. By André Auzi on 2013-05-31

Take into account review remarks

6171. By André Auzi on 2013-05-30

Take into account review comments

Implements:
 * use of ngettext for plural translations
 * use pure SGLite commands for midori_array_count_recursive_by