lp:~aacid/unity8/clazy_run2

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 2014

Michael Zanetti (community): Approve on 2015-10-09

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2015-09-30

Diff: 42 lines (+6/-4)

3 files modified

plugins/Unity/Launcher/desktopfilehandler.cpp (+3/-2)
plugins/Unity/Session/dbusunitysessionservice.cpp (+2/-1)
plugins/Utils/timezoneFormatter.cpp (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1965. By Albert Astals Cid on 2015-09-30

QLatin1Char++

1964. By Albert Astals Cid on 2015-09-29

Make it const too just to make it nicer

1963. By Albert Astals Cid on 2015-09-29

Clazy fixes

Wrap a const char * in QStringLiteral
Do not call first() on non const lists since it detaches

1962. By Albert Astals Cid on 2015-09-29

Merge

1961. By Albert Astals Cid on 2015-09-23

Merge

1960. By Albert Astals Cid on 2015-09-18

Merge unity8

1959. By Albert Astals Cid on 2015-09-14

This is not latin1 so can't use QLatin1String

1958. By Albert Astals Cid on 2015-09-14

Some other fixlets forgotten

1957. By Albert Astals Cid on 2015-09-14

Forgot to commit this change

1956. By Albert Astals Cid on 2015-09-14

Improvements from running clazy over the code

* Use QStringLiterals for literals
* Use QHash on pointers instead of QMap (since the ordering there can't matter)
* Add some QLatin1Strings
* Add some reserve() calls
* Change a QList to QVector since QList is not optimal on big items
* Add some const &

clazy: https://quickgit.kde.org/?p=clazy.git
Ignored tests folder