lp:~kissiel/checkbox/fix-1492320-comment-on-manual-fail

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 4106

Zygmunt Krynicki (community): Approve on 2015-11-18

Paul Larson: Approve on 2015-11-18

Diff: 175 lines (+65/-12)

6 files modified

checkbox-touch/checkbox-touch.qml (+14/-1)
plainbox/docs/changelog.rst (+5/-0)
plainbox/docs/manpages/plainbox-job-units.rst (+6/-0)
plainbox/plainbox/impl/commands/inv_run.py (+8/-0)
plainbox/plainbox/impl/unit/job.py (+21/-11)
plainbox/plainbox/impl/unit/test_job.py (+11/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1492320: Require a comment for a Failure

High

Fix Released

Link a bug report

Related blueprints

4097. By Maciej Kisielewski on 2015-11-04

plainbox:docs:manpages: mention 'explicit-fail' in job unit manpage

Signed-off-by: Maciej Kisielewski <email address hidden>

4096. By Maciej Kisielewski on 2015-11-04

plainbox:docs: mention 'explicit-fail' in the changelog

Signed-off-by: Maciej Kisielewski <email address hidden>

4095. By Maciej Kisielewski on 2015-11-04

plainbox:commands:run: support 'explicit-fail' in plainbox and checkbox-ng

This patch brings support for 'explicit-fail' flag to CLI flavours of checkbox.

Fixes: https://bugs.launchpad.net/checkbox-converged/+bug/1492320

Signed-off-by: Maciej Kisielewski <email address hidden>

4094. By Maciej Kisielewski on 2015-11-04

checkbox-touch: support 'explicit-fail' flag

This patch makes checkbox-touch display the 'add-comment' popup when user fails
a job that flagged as 'explicit-fail'.

Fixes: https://bugs.launchpad.net/checkbox-converged/+bug/1492320

Signed-off-by: Maciej Kisielewski <email address hidden>

4093. By Maciej Kisielewski on 2015-11-04

plainbox:unit:job: fix pep-8 issues

Signed-off-by: Maciej Kisielewski <email address hidden>

4092. By Maciej Kisielewski on 2015-11-04

plainbox:unit:job: add validation of 'explicit-fail' flag

This patch adds validation of 'explicit-fail' flag.

Signed-off-by: Maciej Kisielewski <email address hidden>

4091. By Maciej Kisielewski on 2015-11-04

"automatic merge of lp:~kissiel/checkbox/start-empty-provider/ by tarmac [r=zyga][bug=][author=kissiel]"

4090. By Sylvain Pineau on 2015-11-03

"automatic merge of lp:~sylvain-pineau/checkbox/changelog_update/ by tarmac [r=sylvain-pineau][bug=][author=sylvain-pineau]"

4089. By Maciej Kisielewski on 2015-11-02

"automatic merge of lp:~kissiel/checkbox/fix-1512270-unlatch-rerun/ by tarmac [r=sylvain-pineau][bug=1512270][author=kissiel]"

4088. By Po-Hsu Lin on 2015-11-02

"automatic merge of lp:~cypressyew/checkbox/fix-oops-after-s3-attach/ by tarmac [r=sylvain-pineau][bug=1512258][author=cypressyew]"