lp:~kissiel/checkbox/error-logging-in-cbt-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3922

Zygmunt Krynicki (community): Approve on 2015-07-30

Diff: 50 lines (+13/-5)

3 files modified

checkbox-touch/components/CheckboxTouchApplication.qml (+4/-0)
checkbox-touch/components/ErrorDialog.qml (+0/-2)
checkbox-touch/components/PythonObjectRef.qml (+9/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3923. By Maciej Kisielewski on 2015-07-29

checkbox-touch: handle failed object creation in PythonObjectRef

When creation method call to python failed or misbehaved pyotherside sent in
None as the return value. This was treated as a valid response making
triggering of objectReady signal happen. The worst scenario for this is
PythonLogger construction failing resulting in writes to console.error which in
turn call the 'error' method of the object that is suposed to be a valid python
object, but is None instead.

This patch checks if the creation method returned None (or got None because of
python failing) and prevents the objectReady signal from being fired.

Signed-off-by: Maciej Kisielewski <email address hidden>

3922. By Maciej Kisielewski on 2015-07-29

checkbox-touch: display error popup when session cannot be started

Signed-off-by: Maciej Kisielewski <email address hidden>

3921. By Maciej Kisielewski on 2015-07-29

checkbox-touch: fix errorPopup rendering

This patch makes errorPopup render properly. The qml component that was used as
the displayed item had its width and height set to undefined values, making
runtime to set this as 0 resulting in popup's buttons being not visible and the
text being horribly misplaced.

Signed-off-by: Maciej Kisielewski <email address hidden>

3920. By Maciej Kisielewski on 2015-07-29

"automatic merge of lp:~kissiel/checkbox/validate-providers-in-cbt/ by tarmac [r=zyga][bug=][author=kissiel]"

3919. By Zygmunt Krynicki on 2015-07-28

"automatic merge of lp:~zyga/checkbox/misc-stuff/ by tarmac [r=sylvain-pineau][bug=][author=zyga]"

3918. By Sylvain Pineau on 2015-07-28

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1477423/ by tarmac [r=zyga][bug=1477423][author=sylvain-pineau]"

3917. By Po-Hsu Lin on 2015-07-24

"automatic merge of lp:~cypressyew/checkbox/fix-fswebcam-format/ by tarmac [r=zyga][bug=1435402][author=cypressyew]"

3916. By Launchpad Translations on behalf of checkbox-dev on 2015-07-24

Launchpad automatic translations update.

3915. By Maciej Kisielewski on 2015-07-23

"automatic merge of lp:~kissiel/checkbox/confined-qml-jobs/ by tarmac [r=zyga][bug=][author=kissiel]"

3914. By Maciej Kisielewski on 2015-07-23

"automatic merge of lp:~kissiel/checkbox/rerun-in-cbt/ by tarmac [r=sylvain-pineau][bug=][author=kissiel]"