Merge lp:~zeller-benjamin/ubuntu-sdk-ide/publishcompileinfo into lp:ubuntu-sdk-ide

Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 163
Merged at revision: 163
Proposed branch: lp:~zeller-benjamin/ubuntu-sdk-ide/publishcompileinfo
Merge into: lp:ubuntu-sdk-ide
Diff against target: 85 lines (+28/-1)
2 files modified
dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmode.cpp (+13/-1)
dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmodel.cpp (+15/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-sdk-ide/publishcompileinfo
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+306630@code.launchpad.net

Commit message

Show compile messages on the publish page.

Description of the change

Show compile messages on the publish page.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) :
review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmode.cpp'
--- dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmode.cpp 2016-08-26 14:14:29 +0000
+++ dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmode.cpp 2016-09-23 14:07:40 +0000
@@ -34,6 +34,8 @@
34#include <QScrollArea>34#include <QScrollArea>
3535
36#include <cmakeprojectmanager/cmakeprojectconstants.h>36#include <cmakeprojectmanager/cmakeprojectconstants.h>
37#include <coreplugin/minisplitter.h>
38#include <coreplugin/outputpane.h>
3739
38#include <QScrollArea>40#include <QScrollArea>
39#include <QQuickView>41#include <QQuickView>
@@ -74,7 +76,17 @@
74 container->setMinimumWidth(860);76 container->setMinimumWidth(860);
75 container->setMinimumHeight(548);77 container->setMinimumHeight(548);
76 container->setFocusPolicy(Qt::TabFocus);78 container->setFocusPolicy(Qt::TabFocus);
77 layout->addWidget(container);79
80 auto mainWindowSplitter = new Core::MiniSplitter;
81 mainWindowSplitter->addWidget(container);
82 auto outputPane = new Core::OutputPanePlaceHolder(Ubuntu::Constants::UBUNTU_MODE_PACKAGING, mainWindowSplitter);
83 mainWindowSplitter->addWidget(outputPane);
84 mainWindowSplitter->setStretchFactor(0, 10);
85 mainWindowSplitter->setStretchFactor(1, 0);
86 mainWindowSplitter->setOrientation(Qt::Vertical);
87
88
89 layout->addWidget(mainWindowSplitter);
7890
79 m_modeView->rootContext()->setContextProperty(QLatin1String("publishModel") ,m_viewModel);91 m_modeView->rootContext()->setContextProperty(QLatin1String("publishModel") ,m_viewModel);
80 m_modeView->rootContext()->setContextProperty(QLatin1String("resourceRoot") ,Constants::UBUNTU_DEVICESCREEN_ROOT);92 m_modeView->rootContext()->setContextProperty(QLatin1String("resourceRoot") ,Constants::UBUNTU_DEVICESCREEN_ROOT);
8193
=== modified file 'dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmodel.cpp'
--- dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmodel.cpp 2016-09-22 16:11:03 +0000
+++ dist/qtcreator/src/plugins/ubuntu/src/ubuntu/ubuntupackagingmodel.cpp 2016-09-23 14:07:40 +0000
@@ -44,6 +44,7 @@
44#include <projectexplorer/kit.h>44#include <projectexplorer/kit.h>
45#include <projectexplorer/buildsteplist.h>45#include <projectexplorer/buildsteplist.h>
46#include <projectexplorer/toolchain.h>46#include <projectexplorer/toolchain.h>
47#include <extensionsystem/pluginmanager.h>
47#include <coreplugin/actionmanager/actionmanager.h>48#include <coreplugin/actionmanager/actionmanager.h>
48#include <coreplugin/actionmanager/actioncontainer.h>49#include <coreplugin/actionmanager/actioncontainer.h>
49#include <cmakeprojectmanager/cmakeprojectconstants.h>50#include <cmakeprojectmanager/cmakeprojectconstants.h>
@@ -69,6 +70,17 @@
69 debug = 070 debug = 0
70};71};
7172
73static void showCompileOutputPane ()
74{
75 QObject *paneObj = ExtensionSystem::PluginManager::getObjectByClassName(QStringLiteral("ProjectExplorer::Internal::CompileOutputWindow"));
76 QTC_ASSERT(paneObj != nullptr, return);
77
78 Core::IOutputPane *compileWindow = qobject_cast<Core::IOutputPane *>(paneObj);
79 if (compileWindow) {
80 compileWindow->showPage(Core::IOutputPane::NoModeSwitch);
81 }
82}
83
72UbuntuPackagingModel::UbuntuPackagingModel(QObject *parent) :84UbuntuPackagingModel::UbuntuPackagingModel(QObject *parent) :
73 QObject(parent),85 QObject(parent),
74 m_postPackageTask(Verify)86 m_postPackageTask(Verify)
@@ -540,6 +552,7 @@
540 }552 }
541553
542 ProjectExplorer::BuildManager::buildLists(rawSteps,rawStepMessages);554 ProjectExplorer::BuildManager::buildLists(rawSteps,rawStepMessages);
555 showCompileOutputPane();
543 }556 }
544557
545 } else if(isCMake || isHtml || isQml) {558 } else if(isCMake || isHtml || isQml) {
@@ -586,6 +599,7 @@
586 m_buildManagerConnection = connect(ProjectExplorer::BuildManager::instance(),SIGNAL(buildQueueFinished(bool)),this,SLOT(buildFinished(bool)));599 m_buildManagerConnection = connect(ProjectExplorer::BuildManager::instance(),SIGNAL(buildQueueFinished(bool)),this,SLOT(buildFinished(bool)));
587600
588 ProjectExplorer::BuildManager::buildList(m_packageBuildSteps.last().data(),tr("Build Project"));601 ProjectExplorer::BuildManager::buildList(m_packageBuildSteps.last().data(),tr("Build Project"));
602 showCompileOutputPane();
589 }603 }
590}604}
591605
@@ -640,6 +654,7 @@
640 m_buildManagerConnection = connect(ProjectExplorer::BuildManager::instance(),SIGNAL(buildQueueFinished(bool)),this,SLOT(buildFinished(bool)));654 m_buildManagerConnection = connect(ProjectExplorer::BuildManager::instance(),SIGNAL(buildQueueFinished(bool)),this,SLOT(buildFinished(bool)));
641655
642 ProjectExplorer::BuildManager::buildList(m_packageBuildSteps.last().data(),tr("Build Project"));656 ProjectExplorer::BuildManager::buildList(m_packageBuildSteps.last().data(),tr("Build Project"));
657 showCompileOutputPane();
643}658}
644659
645/*!660/*!

Subscribers

People subscribed via source and target branches