Merge lp:~xnox/whoopsie/fix-realloc into lp:whoopsie
Proposed by
Dimitri John Ledkov
Status: | Needs review |
---|---|
Proposed branch: | lp:~xnox/whoopsie/fix-realloc |
Merge into: | lp:whoopsie |
Diff against target: |
40 lines (+4/-7) 2 files modified
src/identifier.c (+1/-5) src/tests/test_identifier.c (+3/-2) |
To merge this branch: | bzr merge lp:~xnox/whoopsie/fix-realloc |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Lenton (community) | Disapprove | ||
Evan (community) | Approve | ||
Review via email: mp+222584@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 611. By Dimitri John Ledkov
-
Do not try to realloc string literals.
Make a failing test-case, then fix code to use strdup (safe) instead
of doing realloc.
Yikes. Thanks for fixing this!