Merge lp:~xnox/upstart/pyflakes3 into lp:upstart

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 1596
Proposed branch: lp:~xnox/upstart/pyflakes3
Merge into: lp:upstart
Diff against target: 53 lines (+3/-4)
3 files modified
scripts/pyupstart.py.in (+0/-1)
scripts/tests/test_pyupstart_session_init.py (+1/-2)
scripts/upstart-monitor.py (+2/-1)
To merge this branch: bzr merge lp:~xnox/upstart/pyflakes3
Reviewer Review Type Date Requested Status
James Hunt Approve
Review via email: mp+209419@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Fix pyflakes3 warnings.

Revision history for this message
James Hunt (jamesodhunt) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/pyupstart.py.in'
--- scripts/pyupstart.py.in 2014-03-05 10:34:32 +0000
+++ scripts/pyupstart.py.in 2014-03-05 10:51:44 +0000
@@ -15,7 +15,6 @@
15"""15"""
1616
17import os17import os
18import sys
19import logging18import logging
20import tempfile19import tempfile
21import pyinotify20import pyinotify
2221
=== modified file 'scripts/tests/test_pyupstart_session_init.py'
--- scripts/tests/test_pyupstart_session_init.py 2014-03-05 10:34:32 +0000
+++ scripts/tests/test_pyupstart_session_init.py 2014-03-05 10:51:44 +0000
@@ -30,7 +30,6 @@
30import os30import os
31import sys31import sys
32import re32import re
33import json
3433
35base_dir = os.path.abspath(os.path.dirname(__file__))34base_dir = os.path.abspath(os.path.dirname(__file__))
36module_dir = os.path.normpath(os.path.realpath(base_dir + os.sep + '..'))35module_dir = os.path.normpath(os.path.realpath(base_dir + os.sep + '..'))
@@ -81,7 +80,7 @@
81 tmp = '{}{}{}'.format(DEFAULT_SESSION_INSTALL_PATH, os.sep, self.REEXEC_CONF)80 tmp = '{}{}{}'.format(DEFAULT_SESSION_INSTALL_PATH, os.sep, self.REEXEC_CONF)
82 if os.path.exists(tmp):81 if os.path.exists(tmp):
83 print('INFO: UPSTART_TEST_USE_INSTALLED_CONF set - using {} rather than {}'.format(tmp, self.reexec_conf))82 print('INFO: UPSTART_TEST_USE_INSTALLED_CONF set - using {} rather than {}'.format(tmp, self.reexec_conf))
84 reexec_conf = tmp83 self.reexec_conf = tmp
8584
86 self.assertTrue(os.path.exists(self.file_bridge_conf))85 self.assertTrue(os.path.exists(self.file_bridge_conf))
87 self.assertTrue(os.path.exists(self.reexec_conf))86 self.assertTrue(os.path.exists(self.reexec_conf))
8887
=== modified file 'scripts/upstart-monitor.py'
--- scripts/upstart-monitor.py 2013-03-28 09:52:16 +0000
+++ scripts/upstart-monitor.py 2014-03-05 10:51:44 +0000
@@ -40,6 +40,7 @@
40import os40import os
41import sys41import sys
42import gettext42import gettext
43from gettext import gettext as _
43import argparse44import argparse
44import signal45import signal
45import dbus46import dbus
@@ -58,7 +59,7 @@
58cli = False59cli = False
5960
60try:61try:
61 from gi.repository import Gtk, Gdk, GdkPixbuf, GLib62 from gi.repository import Gtk, Gdk, GLib
62except ImportError:63except ImportError:
63 gettext.install(NAME)64 gettext.install(NAME)
64 print("%s: %s" % (_('WARNING'), _('GUI modules not available - falling back to CLI')), file=sys.stderr)65 print("%s: %s" % (_('WARNING'), _('GUI modules not available - falling back to CLI')), file=sys.stderr)

Subscribers

People subscribed via source and target branches