Merge lp:~xnox/ubuntu/saucy/mountall/btrfs into lp:ubuntu/saucy/mountall
Proposed by
Dimitri John Ledkov
Status: | Needs review |
---|---|
Proposed branch: | lp:~xnox/ubuntu/saucy/mountall/btrfs |
Merge into: | lp:ubuntu/saucy/mountall |
Diff against target: |
92 lines (+41/-1) 3 files modified
debian/changelog (+8/-0) debian/control (+1/-1) src/mountall.c (+32/-0) |
To merge this branch: | bzr merge lp:~xnox/ubuntu/saucy/mountall/btrfs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Disapprove | ||
Upstart Reviewers | Pending | ||
Review via email: mp+177822@code.launchpad.net |
Description of the change
Provide better bitter fs support.
* Ignore missing fsck.btrfs
* Skip automatic checking of filesystems with major zero, such as btrfs. (similar is done by sysvinit & checkroot.sh / systemdish systems)
To post a comment you must log in.
Unmerged revisions
- 445. By Dimitri John Ledkov
-
* Allow skipping fsck, when no fsck utility found for btrfs.
* Skip automatic checking of filesystems with major 0, such as btrfs.
* Add myself to uploaders.
I don't think mountall should special case fsck.btrfs. fsck.$fs is a standard interface; btrfs-tools should be supporting this, even if it means making it a symlink to /bin/true - mountall should not be special-casing btrfs, btrfs should be complying with the interfaces.
I'm also not happy with the "major_zero" change. This is way too magic. I think we should get an explanation of why this is the correct check here before including such code.