Merge lp:~xnox/ubiquity/voodoo into lp:ubiquity

Proposed by Dimitri John Ledkov
Status: Merged
Merge reported by: Dimitri John Ledkov
Merged at revision: not available
Proposed branch: lp:~xnox/ubiquity/voodoo
Merge into: lp:ubiquity
Prerequisite: lp:~xnox/ubiquity/r-proposed
Diff against target: 84 lines (+4/-21)
5 files modified
bin/oem-config-firstboot (+0/-8)
debian/changelog (+2/-0)
ubiquity/i18n.py (+1/-5)
ubiquity/plugins/ubi-language.py (+0/-6)
ubiquity/plugins/ubi-timezone.py (+1/-2)
To merge this branch: bzr merge lp:~xnox/ubiquity/voodoo
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+130613@code.launchpad.net

Description of the change

Not sure if some other fontconfigury should be called instead....

To post a comment you must log in.
lp:~xnox/ubiquity/voodoo updated
5763. By Dimitri John Ledkov

Fonconfig-voodoo is gone, not sure if some other "fontconfig"ury
should be called instead. (LP: #1043031)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/oem-config-firstboot'
--- bin/oem-config-firstboot 2012-03-21 20:39:21 +0000
+++ bin/oem-config-firstboot 2012-10-19 17:07:24 +0000
@@ -35,14 +35,6 @@
35# Remove the oem-config-prepare menu item.35# Remove the oem-config-prepare menu item.
36rm -f /usr/share/applications/oem-config-prepare-gtk.desktop \36rm -f /usr/share/applications/oem-config-prepare-gtk.desktop \
37 /usr/share/applications/kde4/oem-config-prepare-kde.desktop37 /usr/share/applications/kde4/oem-config-prepare-kde.desktop
38# Adjust fontconfig configuration, if possible.
39if type fontconfig-voodoo >/dev/null 2>&1; then
40 RET="$(echo GET debian-installer/locale | debconf-communicate)"
41 if [ "${RET%% *}" = 0 ]; then
42 LC_ALL="${RET#* }" fontconfig-voodoo --auto --force --quiet \
43 || true
44 fi
45fi
46# Run a command just before starting oem-config.38# Run a command just before starting oem-config.
47RET="$(echo GET oem-config/early_command | debconf-communicate)" || true39RET="$(echo GET oem-config/early_command | debconf-communicate)" || true
48if [ "${RET%% *}" = 0 ]; then40if [ "${RET%% *}" = 0 ]; then
4941
=== modified file 'debian/changelog'
--- debian/changelog 2012-10-19 17:07:24 +0000
+++ debian/changelog 2012-10-19 17:07:24 +0000
@@ -11,6 +11,8 @@
11 * When auto-partitioning is not possible, allow to manually partition11 * When auto-partitioning is not possible, allow to manually partition
12 the same drive installation medium is on. (LP: #1053030)12 the same drive installation medium is on. (LP: #1053030)
13 * Fix the question_dialog height-for-width (LP: #862270)13 * Fix the question_dialog height-for-width (LP: #862270)
14 * Fonconfig-voodoo is gone, not sure if some other "fontconfig"ury
15 should be called instead. (LP: #1043031)
1416
15 -- Colin Watson <cjwatson@ubuntu.com> Fri, 19 Oct 2012 15:26:28 +010017 -- Colin Watson <cjwatson@ubuntu.com> Fri, 19 Oct 2012 15:26:28 +0100
1618
1719
=== modified file 'ubiquity/i18n.py'
--- ubiquity/i18n.py 2012-09-25 20:59:09 +0000
+++ ubiquity/i18n.py 2012-10-19 17:07:24 +0000
@@ -30,8 +30,7 @@
30from ubiquity import misc, im_switch30from ubiquity import misc, im_switch
3131
3232
33# if 'just_country' is True, only the country is changing33def reset_locale(frontend):
34def reset_locale(frontend, just_country=False):
35 frontend.start_debconf()34 frontend.start_debconf()
36 di_locale = frontend.db.get('debian-installer/locale')35 di_locale = frontend.db.get('debian-installer/locale')
37 if not di_locale:36 if not di_locale:
@@ -47,9 +46,6 @@
47 except locale.Error as e:46 except locale.Error as e:
48 print('locale.setlocale failed: %s (LANG=%s)' % (e, di_locale),47 print('locale.setlocale failed: %s (LANG=%s)' % (e, di_locale),
49 file=sys.stderr)48 file=sys.stderr)
50 if not just_country:
51 misc.execute_root('fontconfig-voodoo',
52 '--auto', '--force', '--quiet')
53 im_switch.start_im()49 im_switch.start_im()
54 return di_locale50 return di_locale
5551
5652
=== modified file 'ubiquity/plugins/ubi-language.py'
--- ubiquity/plugins/ubi-language.py 2012-10-19 17:07:24 +0000
+++ ubiquity/plugins/ubi-language.py 2012-10-19 17:07:24 +0000
@@ -748,10 +748,4 @@
748 locale.setlocale(locale.LC_ALL, '')748 locale.setlocale(locale.LC_ALL, '')
749 except locale.Error:749 except locale.Error:
750 pass750 pass
751 # fontconfig configuration needs to be adjusted based on the
752 # selected locale (from language-selector-common.postinst). Ignore
753 # errors.
754 misc.execute(
755 'chroot', target, 'fontconfig-voodoo',
756 '--auto', '--force', '--quiet')
757 return rv751 return rv
758752
=== modified file 'ubiquity/plugins/ubi-timezone.py'
--- ubiquity/plugins/ubi-timezone.py 2012-09-25 20:59:09 +0000
+++ ubiquity/plugins/ubi-timezone.py 2012-10-19 17:07:24 +0000
@@ -704,8 +704,7 @@
704704
705 def cleanup(self):705 def cleanup(self):
706 plugin.Plugin.cleanup(self)706 plugin.Plugin.cleanup(self)
707 self.ui.controller.set_locale(707 self.ui.controller.set_locale(i18n.reset_locale(self.frontend))
708 i18n.reset_locale(self.frontend, just_country=True))
709708
710709
711class Install(plugin.InstallPlugin):710class Install(plugin.InstallPlugin):

Subscribers

People subscribed via source and target branches

to status/vote changes: