Merge lp:~xnox/ubiquity/fix-crypt-qt-page into lp:ubiquity

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 5909
Proposed branch: lp:~xnox/ubiquity/fix-crypt-qt-page
Merge into: lp:ubiquity
Diff against target: 66 lines (+28/-3)
3 files modified
debian/changelog (+11/-0)
ubiquity/frontend/kde_components/PartAuto.py (+13/-3)
ubiquity/frontend/kde_components/PartMan.py (+4/-0)
To merge this branch: bzr merge lp:~xnox/ubiquity/fix-crypt-qt-page
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+160602@code.launchpad.net
To post a comment you must log in.
lp:~xnox/ubiquity/fix-crypt-qt-page updated
5913. By Dimitri John Ledkov

[Qt Frontend] Clear use as combo box, on each iteration to avoid
duplicated entries. (LP: #1171989) Thanks merryidleness for the patch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-04-23 12:25:58 +0000
+++ debian/changelog 2013-04-24 13:38:26 +0000
@@ -1,3 +1,14 @@
1ubiquity (2.14.7) UNRELEASED; urgency=low
2
3 * [Qt Frontend] Do not allow to proceed from partitioning page when
4 password is required, yet missing or does not match confirmation
5 password. (LP: #1172059)
6
7 * [Qt Frontend] Clear use as combo box, on each iteration to avoid
8 duplicated entries. (LP: #1171989) Thanks merryidleness for the patch.
9
10 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Wed, 24 Apr 2013 11:40:29 +0100
11
1ubiquity (2.14.6) raring; urgency=low12ubiquity (2.14.6) raring; urgency=low
213
3 * Automatic update of included source packages: partman-auto 105ubuntu314 * Automatic update of included source packages: partman-auto 105ubuntu3
415
=== modified file 'ubiquity/frontend/kde_components/PartAuto.py'
--- ubiquity/frontend/kde_components/PartAuto.py 2013-02-19 11:33:07 +0000
+++ ubiquity/frontend/kde_components/PartAuto.py 2013-04-24 13:38:26 +0000
@@ -288,15 +288,25 @@
288 self.password.setEnabled(True)288 self.password.setEnabled(True)
289 self.verified_password.setEnabled(True)289 self.verified_password.setEnabled(True)
290 self.badPassword.setEnabled(True)290 self.badPassword.setEnabled(True)
291 self.verify_password()
291 else:292 else:
292 self.passwordIcon.setEnabled(False)293 self.passwordIcon.setEnabled(False)
293 self.password.setEnabled(False)294 self.password.setEnabled(False)
294 self.verified_password.setEnabled(False)295 self.verified_password.setEnabled(False)
295 self.badPassword.setEnabled(False)296 self.badPassword.setEnabled(False)
297 self.controller.allow_go_forward(True)
296298
297 #show warning if passwords do not match299 #show warning if passwords do not match
298 def verify_password(self):300 def verify_password(self):
299 if self.password.text() != self.verified_password.text():301 complete = False
302
303 if self.password.text() == self.verified_password.text():
304 self.badPassword.hide()
305 complete = True
306 else:
300 self.badPassword.show()307 self.badPassword.show()
301 else:308
302 self.badPassword.hide()309 if not self.password.text():
310 complete = False
311
312 self.controller.allow_go_forward(complete)
303313
=== modified file 'ubiquity/frontend/kde_components/PartMan.py'
--- ubiquity/frontend/kde_components/PartMan.py 2013-02-15 16:56:45 +0000
+++ ubiquity/frontend/kde_components/PartMan.py 2013-04-24 13:38:26 +0000
@@ -178,6 +178,10 @@
178 dialog.partition_create_place_beginning.setChecked(True)178 dialog.partition_create_place_beginning.setChecked(True)
179179
180 self.create_use_method_names = {}180 self.create_use_method_names = {}
181
182 # Remove any previous entries
183 dialog.partition_create_use_combo.clear()
184
181 for method, name, description in (185 for method, name, description in (
182 self.ctrlr.dbfilter.use_as(devpart, True)):186 self.ctrlr.dbfilter.use_as(devpart, True)):
183 self.create_use_method_names[description] = name187 self.create_use_method_names[description] = name

Subscribers

People subscribed via source and target branches

to status/vote changes: