Merge lp:~xnox/debian-cd/only-start-maybe-ubiquity into lp:~ubuntu-cdimage/debian-cd/ubun3

[Dimitri John Ledkov]

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

[Steve Langasek (vorlon)]

This will result in Ubuntu having two options:
 Start Ubuntu
 Install Ubuntu

instead of the current options:
 Try Ubuntu without installing
 Install Ubuntu

Where does this change originate? Is this requested by the Desktop Team? Does the change have Design Team signoff?

review: Needs Information

[Dimitri John Ledkov (xnox)]

Currently, we have 3x and 2x options, for gfxboot and uefi boot respectively.

The gfxboot theme encodes the default of maybe-ubiquity which is hidden; and then displays two text options of only-ubiquity and `try`.

On uefi, there is no hidden menu and only 2x only-ubiquity and `try`.

The proposed option will be 1x only, for both gfxboot and uefi boot, which is just `maybe-ubiquity` this is due to setting NOTRYONLYDO=true variable in that case, which does not generate `Install Ubuntu` option at all..

This is to unify the boot to always boot to maybe-ubiquity. Especially on uefi.

This change originates from the release sprint, acked by willcooke, and fact that the most common boot method, uefi, never uses the pretty maybe-ubiquity welcome screen.

Design team - no idea who would that be, but must people vomit upon seeing EFI grub...

[Dimitri John Ledkov (xnox)]

If you want to test this option, download kubuntu daily-live image, and test it in gfxboot (default timeout), opening gfxboot menu, booting in UEFI mode.

[Steve Langasek (vorlon)]

Ah yes of course, sorry, you're adding this to a section that already has NOTRYONLYDO=yes, so as you say there's only one option being presented at that point.

I do think we should plan to have a high-level design review of these flows (informed by the limitations of the different bootloaders) rather than making incremental adjustments here.

[Martin Wimpress  (flexiondotorg)]

I have concerns about breaking translated strings this late in the cycle, but happy to work on this directly after 20.10 opens.

[Dimitri John Ledkov (xnox)]

UEFI grub menu entries are not translated, there is no translations impact.

BIOS boot remains the same, silently booting into maybe-ubiquity, with try/install options offered if people press esc on keyboard.

[Sebastien Bacher (seb128)]

The commit message states 'in gfx & grub boot', is the string changed or not in gfx boot?
If not then it's inconsistent
It it is then you break translations

[Dimitri John Ledkov (xnox)]

I'll resubmit a clean one then, on top of current debian-cd branch and the right series! (pointed out on irc)

review: Needs Fixing

Unmerged revisions

2005. By Dimitri John Ledkov on 2018-10-17

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

=== modified file 'tools/boot/cosmic/boot-amd64'
--- tools/boot/cosmic/boot-amd64	2018-07-12 05:26:32 +0000
+++ tools/boot/cosmic/boot-amd64	2018-10-17 20:39:46 +0000
@@ -420,7 +420,7 @@
     QUIET=quiet
     SPLASH=splash
     case "$PROJECT" in
-        kubuntu|kubuntu-plasma5)
+        ubuntu|kubuntu|kubuntu-plasma5)
             livelabel="^Start $HUMANPROJECT"
             liveparams=' maybe-ubiquity'
             NOTRYONLYDO=true
 
=== modified file 'tools/boot/cosmic/boot-i386'
--- tools/boot/cosmic/boot-i386	2018-09-30 20:16:30 +0000
+++ tools/boot/cosmic/boot-i386	2018-10-17 20:39:46 +0000
@@ -381,7 +381,7 @@
 EOF
 if [ "$CDIMAGE_LIVE" = 1 ]; then
     case "$PROJECT" in
-        kubuntu|kubuntu-plasma5)
+        ubuntu|kubuntu|kubuntu-plasma5)
             livelabel="^Start $HUMANPROJECT"
             liveparams=' maybe-ubiquity'
             NOTRYONLYDO=true