Merge lp:~xnox/apt-btrfs-snapshot/tools2progs into lp:apt-btrfs-snapshot

Proposed by Dimitri John Ledkov
Status: Needs review
Proposed branch: lp:~xnox/apt-btrfs-snapshot/tools2progs
Merge into: lp:apt-btrfs-snapshot
Diff against target: 81 lines (+12/-8)
5 files modified
apt-btrfs-snapshot (+0/-4)
apt_btrfs_snapshot.py (+3/-3)
debian/changelog (+7/-0)
debian/control (+1/-1)
test/test_apt_btrfs_snapshot.py (+1/-0)
To merge this branch: bzr merge lp:~xnox/apt-btrfs-snapshot/tools2progs
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+346538@code.launchpad.net

Commit message

tools got renamed to progs, and the transitional package is now being dropped.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

ah, and this fails to build, because of new pyflakes / pep8. Oh, well, will need to refix that too.

56. By Dimitri John Ledkov

Fix new pep8/pyflakes warnings.

Unmerged revisions

56. By Dimitri John Ledkov

Fix new pep8/pyflakes warnings.

55. By Dimitri John Ledkov

Change btrfs-tools dependency to progs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'apt-btrfs-snapshot'
--- apt-btrfs-snapshot 2015-10-16 09:27:08 +0000
+++ apt-btrfs-snapshot 2018-05-23 10:13:00 +0000
@@ -19,13 +19,9 @@
1919
2020
21import argparse21import argparse
22import datetime
23import logging22import logging
24import os23import os
25import string
26import subprocess
27import sys24import sys
28import tempfile
2925
30import gettext26import gettext
31from gettext import gettext as _27from gettext import gettext as _
3228
=== modified file 'apt_btrfs_snapshot.py'
--- apt_btrfs_snapshot.py 2016-04-29 15:13:38 +0000
+++ apt_btrfs_snapshot.py 2018-05-23 10:13:00 +0000
@@ -184,7 +184,7 @@
184 If "older_then" is given (in unixtime format) it will only include184 If "older_then" is given (in unixtime format) it will only include
185 snapshots that are older then the given date)185 snapshots that are older then the given date)
186 """186 """
187 l = []187 result = []
188 # if older_than is used, ensure that the rootfs does not use188 # if older_than is used, ensure that the rootfs does not use
189 # "noatime"189 # "noatime"
190 if older_than != 0:190 if older_than != 0:
@@ -203,9 +203,9 @@
203 # created (to check if there is support for btrfs)203 # created (to check if there is support for btrfs)
204 atime = os.path.getatime(os.path.join(mp, e, "etc", "fstab"))204 atime = os.path.getatime(os.path.join(mp, e, "etc", "fstab"))
205 if atime < older_than:205 if atime < older_than:
206 l.append(e)206 result.append(e)
207 self.umount_btrfs_root_volume()207 self.umount_btrfs_root_volume()
208 return l208 return result
209209
210 def print_btrfs_root_snapshots(self):210 def print_btrfs_root_snapshots(self):
211 print("Available snapshots:")211 print("Available snapshots:")
212212
=== modified file 'debian/changelog'
--- debian/changelog 2016-04-29 15:13:38 +0000
+++ debian/changelog 2018-05-23 10:13:00 +0000
@@ -1,3 +1,10 @@
1apt-btrfs-snapshot (3.5.2) cosmic; urgency=medium
2
3 * Change btrfs-tools dependency to progs.
4 * Fix new pep8/pyflakes warnings.
5
6 -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 22 May 2018 10:56:22 +0100
7
1apt-btrfs-snapshot (3.5.1) yakkety; urgency=medium8apt-btrfs-snapshot (3.5.1) yakkety; urgency=medium
29
3 * fix mock of "btrfs" binary10 * fix mock of "btrfs" binary
411
=== modified file 'debian/control'
--- debian/control 2012-10-26 09:27:26 +0000
+++ debian/control 2018-05-23 10:13:00 +0000
@@ -21,7 +21,7 @@
21Depends: ${python:Depends},21Depends: ${python:Depends},
22 ${python3:Depends},22 ${python3:Depends},
23 ${misc:Depends},23 ${misc:Depends},
24 btrfs-tools24 btrfs-progs
25Description: Automatically create snapshot on apt operations25Description: Automatically create snapshot on apt operations
26 This will create a btrfs snapshot of the root filesystem each time26 This will create a btrfs snapshot of the root filesystem each time
27 that apt installs/removes/upgrades a software package. 27 that apt installs/removes/upgrades a software package.
2828
=== modified file 'test/test_apt_btrfs_snapshot.py'
--- test/test_apt_btrfs_snapshot.py 2016-04-29 15:13:38 +0000
+++ test/test_apt_btrfs_snapshot.py 2018-05-23 10:13:00 +0000
@@ -126,5 +126,6 @@
126 t = apt_btrfs._parse_older_than_to_unixtime("5d")126 t = apt_btrfs._parse_older_than_to_unixtime("5d")
127 self.assertTrue((t < time.time()) - (5 * 60 * 60 * 24))127 self.assertTrue((t < time.time()) - (5 * 60 * 60 * 24))
128128
129
129if __name__ == "__main__":130if __name__ == "__main__":
130 unittest.main()131 unittest.main()

Subscribers

People subscribed via source and target branches