Merge lp:~xaav/wikkid/fix-path into lp:wikkid

Proposed by xaav
Status: Needs review
Proposed branch: lp:~xaav/wikkid/fix-path
Merge into: lp:wikkid
Diff against target: 34 lines (+3/-3)
2 files modified
wikkid/dispatcher.py (+2/-2)
wikkid/skin/loader.py (+1/-1)
To merge this branch: bzr merge lp:~xaav/wikkid/fix-path
Reviewer Review Type Date Requested Status
Wikkid Hackers Pending
Review via email: mp+67865@code.launchpad.net

Description of the change

bzrlib.urlutils.dirname returns null on windows, and is slower than the native python implementation.

To post a comment you must log in.
lp:~xaav/wikkid/fix-path updated
71. By xaav

Cleanup.

72. By xaav

Fixed skin path issue.

Unmerged revisions

72. By xaav

Fixed skin path issue.

71. By xaav

Cleanup.

70. By xaav

Fixed path issues on windows.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'wikkid/dispatcher.py'
--- wikkid/dispatcher.py 2010-11-12 09:00:42 +0000
+++ wikkid/dispatcher.py 2011-07-13 17:31:25 +0000
@@ -13,7 +13,7 @@
1313
14import os14import os
1515
16from bzrlib.urlutils import dirname, joinpath16from bzrlib.urlutils import joinpath
1717
18from zope.interface import providedBy18from zope.interface import providedBy
1919
@@ -69,7 +69,7 @@
69# themselves with the view registry.69# themselves with the view registry.
7070
71def load_view_modules():71def load_view_modules():
72 curr_dir = os.path.abspath(dirname(__file__))72 curr_dir = os.path.abspath(os.path.dirname(__file__))
73 view_dir = joinpath(curr_dir, 'view')73 view_dir = joinpath(curr_dir, 'view')
74 py_files = [74 py_files = [
75 filename for filename in os.listdir(view_dir)75 filename for filename in os.listdir(view_dir)
7676
=== modified file 'wikkid/skin/loader.py'
--- wikkid/skin/loader.py 2010-11-05 07:43:31 +0000
+++ wikkid/skin/loader.py 2011-07-13 17:31:25 +0000
@@ -39,7 +39,7 @@
39 'missing': self.env.get_template('missing-page.html'),39 'missing': self.env.get_template('missing-page.html'),
40 'missing-dir' : self.env.get_template('missing-directory.html')40 'missing-dir' : self.env.get_template('missing-directory.html')
41 }41 }
42 module_location = urlutils.dirname(__file__)42 module_location = os.path.dirname(__file__)
43 self.dir_name = urlutils.joinpath(module_location, skin_name)43 self.dir_name = urlutils.joinpath(module_location, skin_name)
4444
45 def get_template(self, template_name):45 def get_template(self, template_name):

Subscribers

People subscribed via source and target branches