Merge lp:~wlxing/ecryptfs/lp1449253 into lp:ecryptfs
Proposed by
Jason Xing
Status: | Merged |
---|---|
Merge reported by: | Tyler Hicks |
Merged at revision: | not available |
Proposed branch: | lp:~wlxing/ecryptfs/lp1449253 |
Merge into: | lp:ecryptfs |
Diff against target: |
42 lines (+16/-1) 2 files modified
doc/manpage/ecryptfs-mount-private.1 (+3/-1) src/utils/ecryptfs-mount-private (+13/-0) |
To merge this branch: | bzr merge lp:~wlxing/ecryptfs/lp1449253 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tyler Hicks | Approve | ||
Jason Xing (community) | Needs Resubmitting | ||
Review via email: mp+325310@code.launchpad.net |
Description of the change
* Fix "ecryptfs-
* Also, update the manpage for ecryptfs-
To post a comment you must log in.
Thanks for the patch!
Just a few nitpicks:
1) Please remove the initial newline in the echo command
2) There shouldn't be a newline after "usage:"
3) The test for $1 being not zero length isn't technically correct. Try this
command to see why:
$ ecryptfs- mount-private "" -h
I think this is the test that you want:
if [ "$#" -ne 0 ]; then
...
Thanks!