Merge lp:~wligtenberg/django-openid-auth/mysql_fix into lp:~django-openid-auth/django-openid-auth/trunk
Proposed by
Willem Ligtenberg
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~wligtenberg/django-openid-auth/mysql_fix | ||||
Merge into: | lp:~django-openid-auth/django-openid-auth/trunk | ||||
Diff against target: |
10 lines (+1/-1) 1 file modified
django_openid_auth/models.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~wligtenberg/django-openid-auth/mysql_fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
django-openid-auth developers | Pending | ||
Review via email: mp+22726@code.launchpad.net |
Description of the change
As mentioned here:
http://
There was an issue with MySQL
Creating table django_
_mysql_
This fix changes the claimed_id to a charfield of 255 length. Which is the maximum for which MySQL has unique support.
This also takes care of bug https:/
To post a comment you must log in.
Unmerged revisions
- 66. By dev <dev@bmt-nb104>
-
MySQL fix
When i've deployed this on mysql backed django applications, I have encountered the same thing and used the fix as proposed in the merge. However, I haven't tested this fix on postgres or sqlite.
The only thing I would say, the "claimed_id" stores the value returned from the provider. The standard launchpad value is something like: /login. launchpad. net/+id/ XXXXXXX
https:/
This is 39 chars. Is it conceivable that a different provider might use a URL longer than 255 chars?
RFC2616 Does hint a recommendation of limiting to 255 bytes - but URL's of >2000 are also popular and supported.