Merge lp:~widelands-dev/widelands/bug-1815613-map-origin-segfault into lp:widelands
Proposed by
GunChleoc
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8985 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug-1815613-map-origin-segfault | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
82 lines (+18/-12) 1 file modified
src/logic/map.cc (+18/-12) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1815613-map-origin-segfault | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
hessenfarmer | test | Approve | |
kaputtnik (community) | testing | Approve | |
Review via email: mp+363080@code.launchpad.net |
Commit message
Fix number overflow in Map::set_origin and clean up the function.
Description of the change
The fix is replacing decltype with size_t, because the positive range of int16_t is too small. The rest is cleanup.
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 4463. State: errored. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 492316137. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1815613_ map_origin_ segfault- 4251.
Appveyor build 4251. State: success. Details: https:/