Merge lp:~widelands-dev/widelands-website/queued_emails into lp:widelands-website

Proposed by kaputtnik
Status: Merged
Merged at revision: 523
Proposed branch: lp:~widelands-dev/widelands-website/queued_emails
Merge into: lp:widelands-website
Diff against target: 52 lines (+12/-3)
3 files modified
pybb/views.py (+2/-2)
settings.py (+9/-0)
wlmaps/models.py (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands-website/queued_emails
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+363951@code.launchpad.net

Commit message

Make use of a global setting to queue emails or not

Description of the change

Added a global setting to use a queue for emails. This makes it possible to queue emails on wl.widelands.org, but not on alpha.widelands.org.

So i do not have to run ./manage.py emit_notices manually on alpha.

After merging add

NOTIFICATION_QUEUE_ALL = True

to local_settings.py of wl.widelands.org

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM

review: Approve
Revision history for this message
kaputtnik (franku) wrote :

Thanks :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'pybb/views.py'
--- pybb/views.py 2018-12-21 13:20:43 +0000
+++ pybb/views.py 2019-03-05 09:11:39 +0000
@@ -201,14 +201,14 @@
201 'post': post,201 'post': post,
202 'user': post.topic.user202 'user': post.topic.user
203 },203 },
204 queue = True)204 )
205 # Topics author is subscriber for all new posts in his topic205 # Topics author is subscriber for all new posts in his topic
206 post.topic.subscribers.add(request.user)206 post.topic.subscribers.add(request.user)
207207
208 else:208 else:
209 # Send mails about a new post to topic subscribers209 # Send mails about a new post to topic subscribers
210 notification.send(post.topic.subscribers.exclude(username=post.user), 'forum_new_post',210 notification.send(post.topic.subscribers.exclude(username=post.user), 'forum_new_post',
211 {'post': post, 'topic': topic, 'user': post.user}, queue = True)211 {'post': post, 'topic': topic, 'user': post.user},)
212212
213 return HttpResponseRedirect(post.get_absolute_url())213 return HttpResponseRedirect(post.get_absolute_url())
214214
215215
=== modified file 'settings.py'
--- settings.py 2019-02-26 13:32:06 +0000
+++ settings.py 2019-03-05 09:11:39 +0000
@@ -358,6 +358,15 @@
358 }358 }
359}359}
360360
361#########################
362# Notification settings #
363#########################
364# When set to True, one has to run ./manage.py emit_notices
365# for sending emails
366
367NOTIFICATION_QUEUE_ALL = False
368
369
361try:370try:
362 from local_settings import *371 from local_settings import *
363except ImportError:372except ImportError:
364373
=== modified file 'wlmaps/models.py'
--- wlmaps/models.py 2018-11-18 17:03:56 +0000
+++ wlmaps/models.py 2019-03-05 09:11:39 +0000
@@ -69,6 +69,6 @@
69 'user': self.uploader,69 'user': self.uploader,
70 'uploader_comment': self.uploader_comment70 'uploader_comment': self.uploader_comment
71 },71 },
72 queue=True)72 )
7373
74 return map74 return map

Subscribers

People subscribed via source and target branches