Merge lp:~whosdaz/ubuntu-qa-website/ubuntu-font-tweak into lp:ubuntu-qa-website

[Matthew Allen]

Changed the websites default font to 'Ubuntu' where possible - I feel as if this is appropriate considering it is the Ubuntu QA Tracker after all.

If the font cannot be loaded from Google web fonts for whatever reason, it will fall back to the current default.

The new font can be seen in this screenshot http://i.imgur.com/I3IoN6l.png

(No point merging this to production unless a bug fix is made though - this can just sit in the new repo as a tweak that will be included in a future release)

[Steve Langasek (vorlon)]

Hi Matthew,

Apologies that this MP was never reviewed!

I'm in the process of preparing to migrate this repository from bzr to git, which means checking for outstanding MPs.

Unfortunately, I don't think I want to merge this as-is, as it introduces a dependency on a third-party website (fonts.googleapis.com) into the code.

I would really prefer to be able to just include https://assets.ubuntu.com/v1/vanilla-framework-version-1.8.0.min.css which is the standard style sheet for Ubuntu websites, but it doesn't play well with drupal assumptions about the markup.

So instead I have extracted the font handling from that stylesheet, and committed the change to the site; you should be able to see it live now on https://iso.qa.ubuntu.com/.

If you have any further suggestions for improvement (... seven years later), feel free to submit them against the git repository which will be live shortly!

review: Disapprove

Unmerged revisions

430. By Matthew Allen on 2016-10-13

Added theme tweak to use the Ubuntu web font

=== modified file 'modules/qatracker/qatracker.module'
--- modules/qatracker/qatracker.module	2016-01-05 15:51:19 +0000
+++ modules/qatracker/qatracker.module	2016-10-13 06:05:15 +0000
@@ -53,7 +53,11 @@
 drupal_add_css("th.select-all { width:0; }", 'inline');
 drupal_add_css("table.sticky-enabled td { vertical-align:top; }", 'inline');
 drupal_add_css("div.form-type-radios .form-radios .form-item { display:inline; padding-right:0.5em; }", 'inline');
+drupal_add_css('https://fonts.googleapis.com/css?family=Ubuntu', array('type' => 'external')); //Use Ubuntu Web Font
 drupal_add_css("
+* {
+  font-family: Ubuntu, sans-serif;
+}
 dl {
   counter-reset: item1;
 }