Merge lp:~wgrant/launchpad/bug-503421 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16552 |
Proposed branch: | lp:~wgrant/launchpad/bug-503421 |
Merge into: | lp:launchpad |
Diff against target: |
58 lines (+37/-0) 2 files modified
lib/lp/translations/model/potemplate.py (+4/-0) lib/lp/translations/tests/test_pofile.py (+33/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-503421 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+157033@code.launchpad.net |
Commit message
When creating shared pofiles, ensure that all of their translation credits strings are set to translated. Previously only the credits string in the initial pofile was translated, leaving the others untranslated if their msgids differed, or there was no credit string in the initial template.
Description of the change
Translation credit messages get automatically populated with a dummy translation by newPOFile. Additionally, newPOFile creates corresponding pofiles in sharing templates if they don't already exist. But it doesn't populate translation credit messages in those sharing pofiles, instead assuming that message sharing will sort it out. This works fine until one of the sharing templates has a credits message that doesn't exist in the original template, leaving the credits in those sharing templates untranslated, making it impossible to reach 100% translation.
I've adjusted newPOFile to populate any credits strings in the other pofiles that it creates. We'll have to rerun the existing credit fixing script once this fix is out.