Merge lp:~vthompson/ubuntu-weather-app/reboot-remove-precip-from-settings into lp:ubuntu-weather-app
Proposed by
Victor Thompson
Status: | Merged |
---|---|
Approved by: | Nekhelesh Ramananthan |
Approved revision: | 58 |
Merged at revision: | 60 |
Proposed branch: | lp:~vthompson/ubuntu-weather-app/reboot-remove-precip-from-settings |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
140 lines (+9/-63) 2 files modified
app/ui/settings/UnitsPage.qml (+0/-36) po/com.ubuntu.weather.pot (+9/-27) |
To merge this branch: | bzr merge lp:~vthompson/ubuntu-weather-app/reboot-remove-precip-from-settings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nekhelesh Ramananthan (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+263210@code.launchpad.net |
Commit message
Remove precip settings from the Settings Page because it is not part of the data shown to the user
Description of the change
Remove precip settings from the Settings Page because it is not part of the data shown to the user. None of the design specs show the total amount of rain being displayed. I suggest we leave the setting in the app's storage for now, just in case we want to introduce it later.
To post a comment you must log in.
PASSED: Continuous integration, rev:58 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/131/ 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- utopic- amd64-ci/ 101 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- vivid-amd64- ci/131
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- weather- app-reboot- ci/131/ rebuild
http://