Merge lp:~vthompson/ubuntu-calendar-app/update-app-colors into lp:ubuntu-calendar-app

Proposed by Victor Thompson
Status: Rejected
Rejected by: David Planella
Proposed branch: lp:~vthompson/ubuntu-calendar-app/update-app-colors
Merge into: lp:ubuntu-calendar-app
Diff against target: 74 lines (+8/-7)
5 files modified
AllDayEventComponent.qml (+1/-1)
MonthComponent.qml (+2/-1)
TimeLineBackground.qml (+1/-1)
TimeSeparator.qml (+1/-1)
calendar.qml (+3/-3)
To merge this branch: bzr merge lp:~vthompson/ubuntu-calendar-app/update-app-colors
Reviewer Review Type Date Requested Status
David Planella Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calendar Developers Pending
Review via email: mp+215348@code.launchpad.net

Commit message

*update app color scheme

Description of the change

This branch is mostly food for thought. How do we want this apps color scheme to look? IMO, I think it should be simplified to align a bit more closely with the branch being proposed here. I think there may be better colors to use, but--again--food for thought.

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

Just a quick download of my thought process. Really, I think the colors that might look nice would be "tooltip" type light yellows and other subtle colors. I chose the orange/peach scheme to be at least a little bit Ubuntu flavored. I'd rather move the scheme closer to something more subtle.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Thanks Victor.

I'd like to have some design input/user testing on this one, before we do any changes. It seems the reason we're changing this is because some users found the colour scheme not pleasant. The thing is, we cannot please everyone, and I'd like to avoid a situation where we keep iterating over this while there is so much higher priority tasks before release.

review: Needs Fixing
Revision history for this message
Mihir Soni (mihirsoni) wrote :

David, did we got any inputs from design team ?

Revision history for this message
David Planella (dpm) wrote :

We discussed this during the sprint in Malta, got input from design and ended up implementing a new color scheme. I'm thus marking this MP as Rejected, as it got superseded by:

https://code.launchpad.net/~popey/ubuntu-calendar-app/new-colours/+merge/220647

review: Disapprove

Unmerged revisions

240. By Victor Thompson

Update app colors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AllDayEventComponent.qml'
--- AllDayEventComponent.qml 2014-04-05 06:36:28 +0000
+++ AllDayEventComponent.qml 2014-04-11 04:33:32 +0000
@@ -16,7 +16,7 @@
1616
17 height: units.gu(6)17 height: units.gu(6)
18 width: parent.width18 width: parent.width
19 color: "#105040"19 color: "#DD4814"
2020
21 function getAllDayEvents(startDate, endDate) {21 function getAllDayEvents(startDate, endDate) {
22 var map = {};22 var map = {};
2323
=== modified file 'MonthComponent.qml'
--- MonthComponent.qml 2014-03-01 02:39:42 +0000
+++ MonthComponent.qml 2014-04-11 04:33:32 +0000
@@ -58,6 +58,7 @@
58 id: ubuntuShape58 id: ubuntuShape
5959
60 anchors.fill: parent60 anchors.fill: parent
61 color: "#FFC793"
61 radius: "medium"62 radius: "medium"
6263
63 Column{64 Column{
@@ -207,7 +208,7 @@
207 text: day.toUpperCase();208 text: day.toUpperCase();
208 horizontalAlignment: Text.AlignHCenter209 horizontalAlignment: Text.AlignHCenter
209 fontSize: root.dayLabelFontSize210 fontSize: root.dayLabelFontSize
210 color: "#AEA79F"211 color: "#FFFFFF"
211 }212 }
212 }213 }
213214
214215
=== modified file 'TimeLineBackground.qml'
--- TimeLineBackground.qml 2013-09-04 13:37:10 +0000
+++ TimeLineBackground.qml 2014-04-11 04:33:32 +0000
@@ -9,7 +9,7 @@
9 delegate: Rectangle {9 delegate: Rectangle {
10 width: parent.width10 width: parent.width
11 height: units.gu(10)11 height: units.gu(10)
12 color: ( index % 2 == 0) ? "#4c875b" : "#86c07f"12 color: ( index % 2 == 0) ? "#FFC793" : "#FF9561"
13 Label{13 Label{
14 id: timeLabel14 id: timeLabel
1515
1616
=== modified file 'TimeSeparator.qml'
--- TimeSeparator.qml 2013-06-01 11:55:55 +0000
+++ TimeSeparator.qml 2014-04-11 04:33:32 +0000
@@ -3,5 +3,5 @@
3Rectangle {3Rectangle {
4 id: separator4 id: separator
5 height: units.gu(0.5)5 height: units.gu(0.5)
6 color: "#c94212"6 color: "#DD4814"
7}7}
88
=== modified file 'calendar.qml'
--- calendar.qml 2014-04-05 08:53:53 +0000
+++ calendar.qml 2014-04-11 04:33:32 +0000
@@ -55,9 +55,9 @@
55 focus: true55 focus: true
56 Keys.forwardTo: [yearView,monthView,weekView,dayView,pageStack.currentPage,tabPage]56 Keys.forwardTo: [yearView,monthView,weekView,dayView,pageStack.currentPage,tabPage]
5757
58 headerColor: "#266249"58 headerColor: "#FFFFFF"
59 backgroundColor: "#478158"59 backgroundColor: "#FFFFFF"
60 footerColor: "#478158"60 footerColor: "#FFFFFF"
61 anchorToKeyboard: true61 anchorToKeyboard: true
6262
63 PageStack {63 PageStack {

Subscribers

People subscribed via source and target branches

to status/vote changes: