Merge lp:~vthompson/music-app/use-qtpowerd-plugin into lp:music-app/trusty

[Victor Thompson]

Use Powerd QML bindings to prevent app from being suspended.

Use Powerd QML bindings to prevent app from being suspended. MP is open now to discuss how the plugin will be used.

[Daniel Holm (danielholm)]

What is MP? And "how the plugin will be used", was that these one-liner codes to hold the Powerd for the music?

[Victor Thompson (vthompson)]

Sorry, MP is just shorthand for 'merge proposal'. And, yes, right now the intent is to just store a boolean property that will toggle the two API calls when called (see the qtpowerd implementation).

[Daniel Holm (danielholm)]

Ah, thank you. Well "powerConnection.keepAlive = mainView.isPlaying" would work, wouldn't it? It's plain and simple.

[Loïc Minier (lool)]

Hey Victor,

Thanks a lot for working on this! I installed qtpowerd from coreapps-drivers daily PPA and patched music-app as above, but that didn't work.

First, I had to explicitly enable the QtDBus module in the .pro file for the .so to load; second, I get:
file:///usr/share/music-app/music-app.qml:509: Error: Cannot assign to non-existent property "keepAlive"
when playing state changes, and in "powerd-cli listen" I see no event coming in.

I can confirm however that this *is* the right approach, as taking an active lock over SSH ("powerd-cli active") is enough for music to keep playing when screen is turned off (if I don't take it, music plays but stutters).

[Loïc Minier (lool)]

Good news, I got this working here; I see the lock appear and disappear in "powerd-cli list"!

I'll push the qtpowerd changes ASAP; the approach in this MP might work, but I think there's a simpler one.

[Loïc Minier (lool)]

I can't mark this as superseded, but would someone please do so? I've proposed an updated version at:
https://code.launchpad.net/~lool/music-app/use-qtpowerd-plugin/+merge/188719

review: Disapprove

[David Planella (dpm)]

Hm, it seems Launchpad merged this automatically just after Loïc's comment?

I'm a bit confused, especially as no Jenkins tests were triggered at all.

Unmerged revisions

=== modified file 'debian/control'
--- debian/control	2013-09-23 19:31:29 +0000
+++ debian/control	2013-09-26 02:25:50 +0000
@@ -8,7 +8,7 @@
 
 Package: music-app
 Architecture: all
-Depends: ${misc:Depends},grilo-plugins-0.2-mediascanner,qtdeclarative5-qtgrilo0.1,qtdeclarative5-localstorage-plugin,qtdeclarative5-particles-plugin,qtdeclarative5-qtmultimedia-plugin,qtdeclarative5-qtquick2-plugin,qtdeclarative5-ubuntu-ui-toolkit-plugin|qt-components-ubuntu,qtdeclarative5-window-plugin,qtdeclarative5-xmllistmodel-plugin,${shlibs:Depends},qmlscene
+Depends: ${misc:Depends},grilo-plugins-0.2-mediascanner,qtdeclarative5-qtgrilo0.1,qtdeclarative5-qtpowerd0.1,qtdeclarative5-localstorage-plugin,qtdeclarative5-particles-plugin,qtdeclarative5-qtmultimedia-plugin,qtdeclarative5-qtquick2-plugin,qtdeclarative5-ubuntu-ui-toolkit-plugin|qt-components-ubuntu,qtdeclarative5-window-plugin,qtdeclarative5-xmllistmodel-plugin,${shlibs:Depends},qmlscene
 Description: Music player for Ubuntu Touch
  Touch enabled music player for Ubuntu
 
 
=== modified file 'music-app.qml'
--- music-app.qml	2013-09-24 13:07:08 +0000
+++ music-app.qml	2013-09-26 02:25:50 +0000
@@ -22,6 +22,7 @@
 import Ubuntu.Components.Popups 0.1
 import Ubuntu.Components.ListItems 0.1 as ListItem
 import Ubuntu.Unity.Action 1.0 as UnityActions
+import Ubuntu.Powerd 0.1
 import org.nemomobile.grilo 0.1
 import QtMultimedia 5.0
 import QtQuick.LocalStorage 2.0
@@ -56,6 +57,12 @@
         }
     }
 
+    // Powerd connection
+    Connections {
+        id: powerConnection
+        target: Powerd
+    }
+
     // HUD Actions
     Action {
         id: nextAction
@@ -496,6 +503,8 @@
         onPlaybackStateChanged: {
           mainView.isPlaying = player.playbackState === MediaPlayer.PlayingState
           console.log("mainView.isPlaying=" + mainView.isPlaying)
+
+          powerConnection.keepAlive = mainView.isPlaying
         }
     }